Re: PATCH 1/2] -Wuninitialized: remove some 'init-self' workarounds

2018-03-20 Thread Junio C Hamano
Ramsay Jones writes: > You may not have noticed that I messed up the Subject line of > this patch - I managed to drop the '[' character in the patch > prefix string. :( I did notice the lack of '[' while reading, and then totally forgot by the time I started queuing

Re: PATCH 1/2] -Wuninitialized: remove some 'init-self' workarounds

2018-03-19 Thread Ramsay Jones
On 19/03/18 17:54, Ramsay Jones wrote: > > The 'self-initialised' variables construct (ie var = var;) has > been used to silence gcc '-W[maybe-]uninitialized' warnings. This has, > unfortunately, caused MSVC to issue 'uninitialized variable' warnings. > Also, using clang static analysis causes

PATCH 1/2] -Wuninitialized: remove some 'init-self' workarounds

2018-03-19 Thread Ramsay Jones
The 'self-initialised' variables construct (ie var = var;) has been used to silence gcc '-W[maybe-]uninitialized' warnings. This has, unfortunately, caused MSVC to issue 'uninitialized variable' warnings. Also, using clang static analysis causes complaints about an 'Assigned value is garbage or