Re: [PATCH] Completion must sort before using uniq

2012-11-23 Thread Joachim Schmitz
Marc Khouzam wrote: The uniq program only works with sorted input. The man page states "uniq prints the unique lines in a sorted file". ... --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -321,7 +321,7 @@ __git_refs ()

Re: [PATCH] Completion must sort before using uniq

2012-11-23 Thread Felipe Contreras
On Thu, Nov 22, 2012 at 5:16 AM, Marc Khouzam wrote: > The uniq program only works with sorted input. The man page states > "uniq prints the unique lines in a sorted file". > > When __git_refs use the guess heuristic employed by checkout for > tracking branches it wants to consider remote branche

RE: [PATCH] Completion must sort before using uniq

2012-11-23 Thread Joachim Schmitz
Re-adding git@vger... > From: Marc Khouzam [mailto:marc.khou...@gmail.com] > Sent: Friday, November 23, 2012 11:51 AM > To: Joachim Schmitz > Cc: sze...@ira.uka.de; felipe.contre...@gmail.com > Subject: Re: [PATCH] Completion must sort before using uniq > > On Fri, No

Re: [PATCH] Completion must sort before using uniq

2012-11-23 Thread Sascha Cunz
> I can't see the difference and in fact don't understand uniq's -u option al > all Linux man pages say: "only print unique lines", but that is what uniq > does by default anyway?!? >From the german translation of uniq's man-page, you can deduct that "only print unique lines" actually means: "pri

RE: [PATCH] Completion must sort before using uniq

2012-11-23 Thread Joachim Schmitz
> From: Sascha Cunz [mailto:sascha...@babbelbox.org] > Sent: Friday, November 23, 2012 1:26 PM > To: Joachim Schmitz > Cc: 'Marc Khouzam'; git@vger.kernel.org; sze...@ira.uka.de; > felipe.contre...@gmail.com > Subject: Re: [PATCH] Completion must sort before using