Re: [PATCH] fast-export: fix regression skipping some merge-commits

Hi Martin, On Fri, 20 Apr 2018, Martin Ågren wrote: > Thanks a lot for your comments. I will give this some testing, check > that your proposed test fails and succeeds as it should, and so on, then > try to wrap this up. Thank you so much! > Between you cleaning up the test and providing a

Re: [PATCH] fast-export: fix regression skipping some merge-commits

Hi Johannes, On 20 April 2018 at 21:07, Johannes Schindelin wrote: > On Fri, 20 Apr 2018, Martin Ågren wrote: > >> Reintroduce the pattern of first grabbing the last object (using a new >> function `object_array_peek()`), then later poping it. Using >> `..._peek()`

Re: [PATCH] fast-export: fix regression skipping some merge-commits

Hi Martin, On Fri, 20 Apr 2018, Martin Ågren wrote: > 7199203937 (object_array: add and use `object_array_pop()`, 2017-09-23) > noted that the pattern `object = array.objects[--array.nr].item` could > be abstracted as `object = object_array_pop()`. > > Unfortunately, one of the conversions was

RE: [PATCH] fast-export: fix regression skipping some merge-commits

Hi Martin, No problem at all. Thanks for the super quick turnaround. :-) Isaac -Original Message- From: Martin Ågren [mailto:martin.ag...@gmail.com] Sent: Friday, April 20, 2018 2:13 PM To: git@vger.kernel.org; Isaac Chou Cc: Junio C Hamano