Re: [PATCH 2/2] http: add an "auto" mode for http.emptyauth

2017-02-25 Thread Jeff King
On Sat, Feb 25, 2017 at 12:48:54PM +0100, Johannes Schindelin wrote: > Hi, > > On Wed, 22 Feb 2017, Jeff King wrote: > > > [two beautiful patches] > > I applied them and verified that the reported issue is fixed. Thank you! > > Hopefully you do not mind that I cherry-picked them in

Re: [PATCH 2/2] http: add an "auto" mode for http.emptyauth

2017-02-25 Thread Johannes Schindelin
Hi, On Wed, 22 Feb 2017, Jeff King wrote: > [two beautiful patches] I applied them and verified that the reported issue is fixed. Thank you! Hopefully you do not mind that I cherry-picked them in preparation for Git for Windows v2.12.0? I added a small fixup

RE: [PATCH 2/2] http: add an "auto" mode for http.emptyauth

2017-02-23 Thread David Turner
Schindelin > <johannes.schinde...@gmx.de>; Eric Sunshine <sunsh...@sunshineco.com> > Subject: Re: [PATCH 2/2] http: add an "auto" mode for http.emptyauth > > On Thu, Feb 23, 2017 at 04:31:13PM +, David Turner wrote: > > > > As somebody who is us

Re: [PATCH 2/2] http: add an "auto" mode for http.emptyauth

2017-02-23 Thread Jeff King
On Thu, Feb 23, 2017 at 04:31:13PM +, David Turner wrote: > > As somebody who is using non-Basic auth, can you apply these patches and > > show us the output of: > > > >GIT_TRACE_CURL=1 \ > >git ls-remote https://your-server 2>&1 >/dev/null | > >egrep '(Send|Recv) header:

RE: [PATCH 2/2] http: add an "auto" mode for http.emptyauth

2017-02-23 Thread David Turner
Schindelin > <johannes.schinde...@gmx.de>; Eric Sunshine <sunsh...@sunshineco.com> > Subject: Re: [PATCH 2/2] http: add an "auto" mode for http.emptyauth > > On Thu, Feb 23, 2017 at 01:16:33AM +, David Turner wrote: > > > I don't know enough a

Re: [PATCH 2/2] http: add an "auto" mode for http.emptyauth

2017-02-22 Thread Jeff King
On Thu, Feb 23, 2017 at 01:16:33AM +, David Turner wrote: > I don't know enough about how libcurl handles authentication to know whether > these patches are a good idea, but I have a minor comment anyway. As somebody who is using non-Basic auth, can you apply these patches and show us the

RE: [PATCH 2/2] http: add an "auto" mode for http.emptyauth

2017-02-22 Thread David Turner
I don't know enough about how libcurl handles authentication to know whether these patches are a good idea, but I have a minor comment anyway. > -Original Message- > From: Jeff King [mailto:p...@peff.net] > +static int curl_empty_auth_enabled(void) { > + if (curl_empty_auth < 0) { >