Re: [PATCH v8 00/12] Fast git status via a file system watcher

2017-10-04 Thread Ben Peart
On 10/4/2017 2:38 AM, Alex Vandiver wrote: On Wed, 4 Oct 2017, Junio C Hamano wrote: Rats indeed. Let's go incremental as promised, perhaps like this (but please supply a better description if you have one). I think you'll also want the following squashed into 5c8cdcfd8 and def437671: --

Re: [PATCH v8 00/12] Fast git status via a file system watcher

2017-10-04 Thread Ben Peart
On 10/3/2017 10:09 PM, Junio C Hamano wrote: Ben Peart writes: Well, rats. I found one more issue that applies to two of the commits. Can you squash this in as well or do you want it in some other form? Rats indeed. Let's go incremental as promised, perhaps like this

Re: [PATCH v8 00/12] Fast git status via a file system watcher

2017-10-04 Thread Alex Vandiver
On Wed, 4 Oct 2017, Junio C Hamano wrote: > Rats indeed. Let's go incremental as promised, perhaps like this > (but please supply a better description if you have one). I think you'll also want the following squashed into 5c8cdcfd8 and def437671: -- >8 -- >From

Re: [PATCH v8 00/12] Fast git status via a file system watcher

2017-10-03 Thread Junio C Hamano
Ben Peart writes: > Well, rats. I found one more issue that applies to two of the > commits. Can you squash this in as well or do you want it in some > other form? Rats indeed. Let's go incremental as promised, perhaps like this (but please supply a better description if

Re: [PATCH v8 00/12] Fast git status via a file system watcher

2017-10-03 Thread Ben Peart
On 10/1/2017 4:24 AM, Junio C Hamano wrote: Ben Peart writes: I had accumulated the same set of changes with one addition of removing a duplicate "the" from a comment in the fsmonitor.h file: diff --git a/fsmonitor.h b/fsmonitor.h index 8eb6163455..0de644e01a

Re: [PATCH v8 00/12] Fast git status via a file system watcher

2017-10-01 Thread Junio C Hamano
Ben Peart writes: > I had accumulated the same set of changes with one addition of removing > a duplicate "the" from a comment in the fsmonitor.h file: > > diff --git a/fsmonitor.h b/fsmonitor.h > index 8eb6163455..0de644e01a 100644 > --- a/fsmonitor.h > +++

RE: [PATCH v8 00/12] Fast git status via a file system watcher

2017-09-29 Thread Ben Peart
johannes.schinde...@gmx.de; pclo...@gmail.com; p...@peff.net > Subject: Re: [PATCH v8 00/12] Fast git status via a file system watcher > > Ben Peart <benpe...@microsoft.com> writes: > > > The only behavioral change from V7 is the removal of unnecessary uses > > o

Re: [PATCH v8 00/12] Fast git status via a file system watcher

2017-09-28 Thread Junio C Hamano
Ben Peart writes: > The only behavioral change from V7 is the removal of unnecessary uses of > CE_MATCH_IGNORE_FSMONITOR. With a better understanding of *why* the > CE_MATCH_IGNORE_* flags are used, it is now clear they are not required > in most cases where