Re: git commit results in many lstat()s

2017-02-01 Thread brian m. carlson
On Thu, Feb 02, 2017 at 12:14:30AM +, Gumbel, Matthew K wrote: > I'm testing such a change locally. Git test suite seems to be running for > quite > a while. Do you know any way to run it in parallel or otherwise speed it > up? I usually do something like the following: make -j3 all && (cd

RE: git commit results in many lstat()s

2017-02-01 Thread Gumbel, Matthew K
"Junio C Hamano writes: "Gumbel, Matthew K" writes: >> Yes, I think that when the user passes --only flag to git-commit, then git >> does not >> need to call refresh_cache() in prepare_index() in builtin/commit.c. >> >> I may experiment with that. Do you see any downs

Re: git commit results in many lstat()s

2017-02-01 Thread Junio C Hamano
"Gumbel, Matthew K" writes: > "Junio C Hamano" writes: >> There probably are other things that can be optimized. > > Yes, I think that when the user passes --only flag to git-commit, then git > does not > need to call refresh_cache() in prepare_index() in builtin/commit.c. > > I may experiment

RE: git commit results in many lstat()s

2017-02-01 Thread Gumbel, Matthew K
"Junio C Hamano" writes: > There probably are other things that can be optimized. Yes, I think that when the user passes --only flag to git-commit, then git does not need to call refresh_cache() in prepare_index() in builtin/commit.c. I may experiment with that. Do you see any downside or negat

Re: git commit results in many lstat()s

2017-02-01 Thread Junio C Hamano
"Gumbel, Matthew K" writes: > I do not understand why git commit must call lstat() on every file > in the repository, even when I specify the name of the file I want > to commit on the command line. Assuming the "COPYING" and "README.md" files are already tracked: $ >COPYING $ >README.m