Re: RFC: git bisect should accept paths-to-be-excluded

2013-09-17 Thread Christian Couder
Hi, On Mon, Sep 16, 2013 at 2:39 PM, Toralf Förster toralf.foers...@gmx.de wrote: I'm bisecting a linux kernel issue and want to ignore all commits just touching something in ./drives/staging. Currently the only way would be to specify all dir/subdir combination under ./linux except that

Re: RFC: git bisect should accept paths-to-be-excluded

2013-09-17 Thread Matthieu Moy
Christian Couder christian.cou...@gmail.com writes: In practice though, as git bisect is a kind of binary search, if what you want to exclude is exclusively touched by half the commits, it will only add one more bisection step if you don't exclude it. Actually, I think the same remark would

Re: RFC: git bisect should accept paths-to-be-excluded

2013-09-17 Thread Christian Couder
On Tue, Sep 17, 2013 at 10:21 AM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Christian Couder christian.cou...@gmail.com writes: In practice though, as git bisect is a kind of binary search, if what you want to exclude is exclusively touched by half the commits, it will only add one

Re: RFC: git bisect should accept paths-to-be-excluded

2013-09-17 Thread Duy Nguyen
On Tue, Sep 17, 2013 at 4:03 PM, Christian Couder christian.cou...@gmail.com wrote: On Tue, Sep 17, 2013 at 10:21 AM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Christian Couder christian.cou...@gmail.com writes: In practice though, as git bisect is a kind of binary search, if what you

Re: RFC: git bisect should accept paths-to-be-excluded

2013-09-17 Thread Toralf Förster
On 09/17/2013 09:26 AM, Christian Couder wrote: Hi, On Mon, Sep 16, 2013 at 2:39 PM, Toralf Förster toralf.foers...@gmx.de wrote: I'm bisecting a linux kernel issue and want to ignore all commits just touching something in ./drives/staging. Currently the only way would be to specify all

Re: RFC: git bisect should accept paths-to-be-excluded

2013-09-17 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: On Tue, Sep 17, 2013 at 4:03 PM, Christian Couder christian.cou...@gmail.com wrote: On Tue, Sep 17, 2013 at 10:21 AM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Christian Couder christian.cou...@gmail.com writes: In practice though, as git bisect

Re: RFC: git bisect should accept paths-to-be-excluded

2013-09-17 Thread Piotr Krukowiecki
Junio C Hamano gits...@pobox.com napisał: Yeah, it is easy to say that git log -- A ':(exclude)A/B' A/B/C has two positive (A, A/B/C) and one negative (A/B), and then the most specific one A/B/C matches a path A/B/C/D and hence A/B/C/D is included. But to actually _design_ it, there are

Re: RFC: git bisect should accept paths-to-be-excluded

2013-09-17 Thread Junio C Hamano
Piotr Krukowiecki piotr.krukowie...@gmail.com writes: What about simply iterating over options in order in which they are specified and the last option that matches specifies the result? But isn't it very inconsistent from the way normal pathspec works? git log -- A B and git log -- B A

Re: RFC: git bisect should accept paths-to-be-excluded

2013-09-17 Thread Piotr Krukowiecki
On Tue, Sep 17, 2013 at 9:04 PM, Junio C Hamano gits...@pobox.com wrote: Piotr Krukowiecki piotr.krukowie...@gmail.com writes: What about simply iterating over options in order in which they are specified and the last option that matches specifies the result? But isn't it very

Re: RFC: git bisect should accept paths-to-be-excluded

2013-09-17 Thread Junio C Hamano
Piotr Krukowiecki piotr.krukowie...@gmail.com writes: Ignoring (possible) inconsistency thing, I think they are easy to understand and use. Probably you are right (in the sense that I do not offhand think of a confusing and ambiguous set of positive and negative pathspecs; others may find

RFC: git bisect should accept paths-to-be-excluded

2013-09-16 Thread Toralf Förster
I'm bisecting a linux kernel issue and want to ignore all commits just touching something in ./drives/staging. Currently the only way would be to specify all dir/subdir combination under ./linux except that particular directory, right ? -- MfG/Sincerely Toralf Förster pgp finger print: 7B1A