Re: Re*: [PATCH v3] fetch: replace string-list used as a look-up table with a hashmap

2018-10-31 Thread Johannes Schindelin
Hi Junio, On Sat, 27 Oct 2018, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Just one thing^W^Wa couple of things: > > > > It would probably make more sense to `hashmap_get_from_hash()` and > > `strhash()` here (and `strhash()` should probably be used everywhere > > instead of

Re*: [PATCH v3] fetch: replace string-list used as a look-up table with a hashmap

2018-10-27 Thread Junio C Hamano
Johannes Schindelin writes: > Just one thing^W^Wa couple of things: > > It would probably make more sense to `hashmap_get_from_hash()` and > `strhash()` here (and `strhash()` should probably be used everywhere > instead of `memhash(str, strlen(str))`). hashmap_get_from_hash() certainly is much

Re: [PATCH v3] fetch: replace string-list used as a look-up table with a hashmap

2018-10-22 Thread Johannes Schindelin
Hi Junio, On Fri, 19 Oct 2018, Junio C Hamano wrote: > In find_non_local_tags() helper function (used to implement the > "follow tags"), we use string_list_has_string() on two string lists > as a way to see if a refname has already been processed, etc. > > All this code predates more modern