Re: [Bug] git branch -v has problems with carriage returns

2017-05-31 Thread Junio C Hamano
Atousa Duprat writes: > Here is my first attempt at fixing the issue. > > There are two problems in ref-filter.c: > > First, copy_subject() has been modified to turn '\n' into a space and > every other ascii control character to be ignored. > > Second, find_subpos() doesn't realize that a line th

Re: [Bug] git branch -v has problems with carriage returns

2017-05-31 Thread Stefan Beller
On Tue, May 30, 2017 at 10:32 PM, Atousa Duprat wrote: > Here is my first attempt at fixing the issue. Cool you're looking into this. :) > > There are two problems in ref-filter.c: > > First, copy_subject() has been modified to turn '\n' into a space and > every other ascii control character to

Re: [Bug] git branch -v has problems with carriage returns

2017-05-30 Thread Atousa Duprat
Here is my first attempt at fixing the issue. There are two problems in ref-filter.c: First, copy_subject() has been modified to turn '\n' into a space and every other ascii control character to be ignored. Second, find_subpos() doesn't realize that a line that only contains a '\r\n' is a blank

Re: [Bug] git branch -v has problems with carriage returns

2017-05-19 Thread Johannes Sixt
Am 19.05.2017 um 23:55 schrieb Atousa Duprat: I have tried to repro this issue but git goes out of its way to store the commit messages using unix end-of-line format. I think that git itself cannot create a repo exhibiting this problem. Here is a recipe to reproduce the error: git init git

Re: [Bug] git branch -v has problems with carriage returns

2017-05-19 Thread Animi Vulpis
No problem, thanks for taking the time to help me. I managed to create a minimal repository that shows the bug. (I was able to deploy gitlab-ce-v8.15.8-ce.0 from docker locally and create the repo, create the merge request and merge it) I created a github repository so everybody interested can us

Re: [Bug] git branch -v has problems with carriage returns

2017-05-19 Thread Atousa Duprat
Sorry for the noise with previous response... I have tried to repro this issue but git goes out of its way to store the commit messages using unix end-of-line format. I think that git itself cannot create a repo exhibiting this problem. Most helpful would be if you could create a mini repo using