Re: [PATCH] [submodule] Add depth to submodule update

2013-06-24 Thread Junio C Hamano
Summoning area experts ;-) Thanks. Fredrik Gustafsson writes: > Used only when a clone is initialized. This is useful when the submodule(s) > are huge and you're not really interested in anything but the latest commit. > > Signed-off-by: Fredrik Gustafsson > --- > git-submodule.sh | 13 ++

Re: [PATCH] [submodule] Add depth to submodule update

2013-06-25 Thread Heiko Voigt
On Tue, Jun 25, 2013 at 12:49:25AM +0200, Fredrik Gustafsson wrote: > Used only when a clone is initialized. This is useful when the submodule(s) > are huge and you're not really interested in anything but the latest commit. > > Signed-off-by: Fredrik Gustafsson I this is a valid use case. But t

Re: [PATCH] [submodule] Add depth to submodule update

2013-06-26 Thread Fredrik Gustafsson
On Wed, Jun 26, 2013 at 12:11:32AM +0200, Heiko Voigt wrote: > On Tue, Jun 25, 2013 at 12:49:25AM +0200, Fredrik Gustafsson wrote: > > Used only when a clone is initialized. This is useful when the submodule(s) > > are huge and you're not really interested in anything but the latest commit. > > >

Re: [PATCH] [submodule] Add depth to submodule update

2013-06-26 Thread Junio C Hamano
Heiko Voigt writes: > On Tue, Jun 25, 2013 at 12:49:25AM +0200, Fredrik Gustafsson wrote: >> Used only when a clone is initialized. This is useful when the submodule(s) >> are huge and you're not really interested in anything but the latest commit. >> >> Signed-off-by: Fredrik Gustafsson > > I

Re: [PATCH] [submodule] Add depth to submodule update

2013-06-26 Thread Junio C Hamano
Fredrik Gustafsson writes: > On Wed, Jun 26, 2013 at 12:11:32AM +0200, Heiko Voigt wrote: >> On Tue, Jun 25, 2013 at 12:49:25AM +0200, Fredrik Gustafsson wrote: >> > Used only when a clone is initialized. This is useful when the submodule(s) >> > are huge and you're not really interested in anyth

Re: [PATCH] [submodule] Add depth to submodule update

2013-06-27 Thread Jens Lehmann
Am 26.06.2013 23:03, schrieb Junio C Hamano: > Fredrik Gustafsson writes: > >> On Wed, Jun 26, 2013 at 12:11:32AM +0200, Heiko Voigt wrote: >>> On Tue, Jun 25, 2013 at 12:49:25AM +0200, Fredrik Gustafsson wrote: Used only when a clone is initialized. This is useful when the submodule(s)

Re: [PATCH] [submodule] Add depth to submodule update

2013-06-28 Thread Junio C Hamano
Heiko Voigt writes: > On Thu, Jun 27, 2013 at 04:54:45PM +0200, Jens Lehmann wrote: > ... >> Me too thinks adding "--depth" to "update" makes sense (and I don't >> think that this pretty generic name will become a problem later in >> case someone wants to add a maximum recursion depth, as grep al

Re: [PATCH] [submodule] Add depth to submodule update

2013-06-28 Thread Jens Lehmann
Am 28.06.2013 20:44, schrieb Junio C Hamano: > Heiko Voigt writes: > >> On Thu, Jun 27, 2013 at 04:54:45PM +0200, Jens Lehmann wrote: >> ... >>> Me too thinks adding "--depth" to "update" makes sense (and I don't >>> think that this pretty generic name will become a problem later in >>> case some

Re: [PATCH] [submodule] Add depth to submodule update

2013-06-28 Thread Junio C Hamano
Jens Lehmann writes: > Am 28.06.2013 20:44, schrieb Junio C Hamano: >> Heiko Voigt writes: >> ... >>> Hmm, but does it have a --depth option for revisions? Maybe we should >>> call it --clone-depth or --rev-depth to make it clear? --depth and >>> --max-depth would be completely orthogonal but t

Re: [PATCH] [submodule] Add depth to submodule update

2013-06-28 Thread Fredrik Gustafsson
On Fri, Jun 28, 2013 at 03:51:41PM -0700, Junio C Hamano wrote: > Jens Lehmann writes: > > > Am 28.06.2013 20:44, schrieb Junio C Hamano: > >> Heiko Voigt writes: > >> ... > >>> Hmm, but does it have a --depth option for revisions? Maybe we should > >>> call it --clone-depth or --rev-depth to m

Re: [PATCH] [submodule] Add depth to submodule update

2013-06-30 Thread Junio C Hamano
Fredrik Gustafsson writes: >> OK, then "--depth" it is. >> >> The points in your review on the last version with "--depth" (which >> I picked up and parked on 'pu') still need to be addressed, I think? > > I agree, I'm on it Thanks. -- To unsubscribe from this list: send the line "unsubscribe g

Re: Re: [PATCH] [submodule] Add depth to submodule update

2013-06-27 Thread Heiko Voigt
On Thu, Jun 27, 2013 at 04:54:45PM +0200, Jens Lehmann wrote: > Am 26.06.2013 23:03, schrieb Junio C Hamano: > > Fredrik Gustafsson writes: > > > >> On Wed, Jun 26, 2013 at 12:11:32AM +0200, Heiko Voigt wrote: > >>> On Tue, Jun 25, 2013 at 12:49:25AM +0200, Fredrik Gustafsson wrote: > Used o