Re: [PATCH] Fix `git rev-list --show-notes HEAD` when there are no notes

2015-08-24 Thread Johannes Schindelin
Hi Peff, On 2015-08-24 16:43, Jeff King wrote: On Mon, Aug 24, 2015 at 12:23:52PM +0200, Johannes Schindelin wrote: You're right. I think the best approach for now is to error out when `--show-notes` is passed to rev-list. Do you agree? Yes (I imagine you didn't yet read my follow-up

Re: [PATCH] Fix `git rev-list --show-notes HEAD` when there are no notes

2015-08-24 Thread Jeff King
On Mon, Aug 24, 2015 at 12:23:52PM +0200, Johannes Schindelin wrote: You're right. I think the best approach for now is to error out when `--show-notes` is passed to rev-list. Do you agree? Yes (I imagine you didn't yet read my follow-up patch when you wrote this). :) -Peff -- To unsubscribe

Re: [PATCH] Fix `git rev-list --show-notes HEAD` when there are no notes

2015-08-24 Thread Johannes Schindelin
Hi Peff, On 2015-08-23 19:43, Jeff King wrote: On Sat, Aug 22, 2015 at 05:14:39PM +0200, Johannes Schindelin wrote: The `format_display_notes()` function clearly assumes that the data structure holding the notes has been initialized already, i.e. that the `display_notes_trees` variable is

Re: [PATCH] Fix `git rev-list --show-notes HEAD` when there are no notes

2015-08-23 Thread Jeff King
On Sat, Aug 22, 2015 at 05:14:39PM +0200, Johannes Schindelin wrote: The `format_display_notes()` function clearly assumes that the data structure holding the notes has been initialized already, i.e. that the `display_notes_trees` variable is no longer `NULL`. However, when there are no

Re: [PATCH] Fix `git rev-list --show-notes HEAD` when there are no notes

2015-08-22 Thread Johan Herland
On Sat, Aug 22, 2015 at 5:14 PM, Johannes Schindelin johannes.schinde...@gmx.de wrote: The `format_display_notes()` function clearly assumes that the data structure holding the notes has been initialized already, i.e. that the `display_notes_trees` variable is no longer `NULL`. However, when