Re: [PATCH] Revert diffstat back to English

2012-09-14 Thread Nguyen Thai Ngoc Duy
On Fri, Sep 14, 2012 at 11:54 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Nguyễn Thái Ngọc Duy writes: >> >>> This reverts the i18n part of 7f81463 (Use correct grammar in diffstat >>> summary line - 2012-02-01) but still keeps the grammar correctness for >>> English. It also revert

Re: [PATCH] Revert diffstat back to English

2012-09-14 Thread Junio C Hamano
Junio C Hamano writes: > Nguyễn Thái Ngọc Duy writes: > >> This reverts the i18n part of 7f81463 (Use correct grammar in diffstat >> summary line - 2012-02-01) but still keeps the grammar correctness for >> English. It also reverts b354f11 (Fix tests under GETTEXT_POISON on >> diffstat - 2012-0

Re: [PATCH] Revert diffstat back to English

2012-09-14 Thread Nguyen Thai Ngoc Duy
On Fri, Sep 14, 2012 at 7:11 AM, Jeff King wrote: > On Thu, Sep 13, 2012 at 02:47:09PM -0700, Junio C Hamano wrote: > >> > I agree that the line is not bright. I do not know if it is worthwhile >> > or not. I think it will solve some practical problems, but it may also >> > introduce others. But

Re: [PATCH] Revert diffstat back to English

2012-09-13 Thread Jeff King
On Thu, Sep 13, 2012 at 02:47:09PM -0700, Junio C Hamano wrote: > > I agree that the line is not bright. I do not know if it is worthwhile > > or not. I think it will solve some practical problems, but it may also > > introduce others. But basically having a per-repo LANG setting (which > > is wh

Re: [PATCH] Revert diffstat back to English

2012-09-13 Thread Junio C Hamano
Jeff King writes: > On Thu, Sep 13, 2012 at 02:26:55PM -0700, Junio C Hamano wrote: > >> Jeff King writes: >> >> > I do not think they are incompatible if you separate it into three >> > categories: machine readable (must never be translated), for the current >> > user right now (current i18n),

Re: [PATCH] Revert diffstat back to English

2012-09-13 Thread Jeff King
On Thu, Sep 13, 2012 at 02:26:55PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > I do not think they are incompatible if you separate it into three > > categories: machine readable (must never be translated), for the current > > user right now (current i18n), and for sharing with other

Re: [PATCH] Revert diffstat back to English

2012-09-13 Thread Junio C Hamano
Jeff King writes: > I do not think they are incompatible if you separate it into three > categories: machine readable (must never be translated), for the current > user right now (current i18n), and for sharing with other humans > (i18n.projectlang). Anything you see as a user is potentially use

Re: [PATCH] Revert diffstat back to English

2012-09-13 Thread Jeff King
On Thu, Sep 13, 2012 at 02:10:41PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > I suspect we will end up with people not setting i18n.projectlang, and > > getting Klingon diffstats on the list. > > Yes, but when our starting point is that the diffstat summary is not > meant for machin

Re: [PATCH] Revert diffstat back to English

2012-09-13 Thread Junio C Hamano
Jeff King writes: > I suspect we will end up with people not setting i18n.projectlang, and > getting Klingon diffstats on the list. Yes, but when our starting point is that the diffstat summary is not meant for machine consumption, which I tend to agree, that is a logical consequence no matter h

Re: [PATCH] Revert diffstat back to English

2012-09-13 Thread Jeff King
On Thu, Sep 13, 2012 at 11:40:12AM -0700, Junio C Hamano wrote: > > More than one people explicitly said that they do not want to see > > this in Klingon. Even if the system is fully internationalized, > > these "... (+), ... (-)" should never be localized, just like we > > will never localize "d

Re: [PATCH] Revert diffstat back to English

2012-09-13 Thread Junio C Hamano
Junio C Hamano writes: > Nguyễn Thái Ngọc Duy writes: > >> Git is still partly i18n-ized, turning a few strings back does not >> seem a big regression. > > More than one people explicitly said that they do not want to see > this in Klingon. Even if the system is fully internationalized, > the

Re: [PATCH] Revert diffstat back to English

2012-09-13 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Git is still partly i18n-ized, turning a few strings back does not > seem a big regression. More than one people explicitly said that they do not want to see this in Klingon. Even if the system is fully internationalized, these "... (+), ... (-)" should never be

Re: [PATCH] Revert diffstat back to English

2012-09-13 Thread Jeff King
On Thu, Sep 13, 2012 at 09:16:26PM +0700, Nguyen Thai Ngoc Duy wrote: > This reverts the i18n part of 7f81463 (Use correct grammar in diffstat > summary line - 2012-02-01) but still keeps the grammar correctness for > English. It also reverts b354f11 (Fix tests under GETTEXT_POISON on > diffstat -