Re: [PATCH] config: added --expiry-date type support

2017-11-12 Thread Kevin Daudt
On Sun, Nov 12, 2017 at 12:19:35PM +, Haaris wrote: > --- > builtin/config.c | 11 ++- > config.c | 9 + > config.h | 1 + > t/t1300-repo-config.sh | 25 + > 4 files changed, 45 insertions(+), 1 deletion(-) > > diff -

Re: [PATCH] config: added --expiry-date type support

2017-11-12 Thread Jeff King
On Sun, Nov 12, 2017 at 02:55:53PM +0100, Kevin Daudt wrote: > What I'm also missing is a motivation on why you added this option, > which should be part of your commit message. As far as I know, there is > currently no config setting that expects a date format. This patch came from submitGit, an

Re: [PATCH] config: added --expiry-date type support

2017-11-12 Thread Jeff King
On Sun, Nov 12, 2017 at 12:19:35PM +, Haaris wrote: > --- Hi, and welcome to the list. Thanks for working on this (for those of you on the list, this was one of the tasks at the hackathon this weekend). Kevin already mentioned a few things about the commit message, which I agree with. > bu

Re: [PATCH] config: added --expiry-date type support

2017-11-12 Thread hsed
On 2017-11-12 14:55, Jeff King wrote: Hi, and welcome to the list. Thanks for working on this (for those of you on the list, this was one of the tasks at the hackathon this weekend). It was a pleasure meeting everyone and a great experience! Kevin already mentioned a few things about the com