Re: [PATCH] config.c: handle error case for fstat() calls

On Mon, Dec 19, 2016 at 10:14:27AM -0800, Junio C Hamano wrote: > Shouldn't the error-return path in the second hunk rollback the > lockfile to clean after itself? The existing "Oh, we cannot chmod > to match the original" check that comes immediately after shares the > same issue, so this is not

Re: [PATCH] config.c: handle error case for fstat() calls

Nguyễn Thái Ngọc Duy writes: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > Will this fix the problem I'm replying to? I don't know. I found this > while checking the code and it should be fixed regardless. Yeah, from a cursory read, it is a step in the right direction to check the return val