Re: [PATCH] credential-cache: close stderr in daemon process

2014-09-16 Thread Junio C Hamano
Jeff King p...@peff.net writes: Squash this in? Yeah, I did a crude one without _errno() while sending the report; will replace. Thanks. diff --git a/credential-cache--daemon.c b/credential-cache--daemon.c index c07a67c..c2f0049 100644 --- a/credential-cache--daemon.c +++

Re: [PATCH] credential-cache: close stderr in daemon process

2014-09-15 Thread Junio C Hamano
Jeff King p...@peff.net writes: + if (!debug) + freopen(/dev/null, w, stderr); I am getting this: credential-cache--daemon.c:216:10: error: ignoring return value of 'freopen', declared with attribute warn_unused_result [-Werror=unused-result] which is somewhat irritating.

Re: [PATCH] credential-cache: close stderr in daemon process

2014-09-15 Thread Jeff King
On Mon, Sep 15, 2014 at 02:38:11PM -0700, Junio C Hamano wrote: Jeff King p...@peff.net writes: + if (!debug) + freopen(/dev/null, w, stderr); I am getting this: credential-cache--daemon.c:216:10: error: ignoring return value of 'freopen', declared with attribute