Matt McCutchen writes:
> Anyway, I made a split series and will send it in a moment. I don't
> know if all the commit messages include exactly the information you
> want; hopefully you're happy to edit them as desired. Compared to the
> previous patch, there is one fix in the net result: fixing
On Mon, 2017-02-20 at 22:36 -0800, Junio C Hamano wrote:
> Hmph, I would have expected this to be done as a three-patch series,
>
> * move the loop at the end of cmd_fetch_pack() to a separate helper
> function report_unmatched_refs() and call it;
>
> * add a call to report_unmatched_refs()
Matt McCutchen writes:
> Currently "git fetch REMOTE SHA1" silently exits 1 if the server doesn't
> allow requests for unadvertised objects by sha1. The more common case
> of requesting a nonexistent ref normally triggers a die() in
> get_fetch_map, so "git fetch" wasn't bothering to check after
On Sun, 2017-02-12 at 15:49 -0800, Junio C Hamano wrote:
> The fact that we have the above two choices tells me that a two-step
> approach may be an appropriate approach. [...]
> Even if you did only the first step, as long as the second step can
> be done without reverting what the first step did
Matt McCutchen writes:
> What do you think? Do you not care about having a more specific error,
> in which case I can copy the code from builtin/fetch-pack.c to
> fetch_refs_via_pack? Or shall I add code to filter_refs to set a flag
> and add code to builtin/fetch-pack.c and fetch_refs_via_pack
On Fri, 2017-02-10 at 10:36 -0800, Junio C Hamano wrote:
> >
> There is this piece of code near the end of builtin/fetch-pack.c:
>
> [...]
>
> that happens before the command shows the list of fetched refs, and
> this code is prepared to inspect what happend to the requests it (in
> response to
Matt McCutchen writes:
> Currently "git fetch REMOTE SHA1" silently exits 1 if the server doesn't
> allow requests for unadvertised objects by sha1. Change it to print a
> meaningful error message.
>
> Signed-off-by: Matt McCutchen
> ---
>
> The fetch code looks unbelievably complicated to me a
7 matches
Mail list logo
