Re: [PATCH] git-p4: add failing tests for case-folding p4d

2015-04-29 Thread Luke Diamand
(Adding Pete, Vitor, and Fusion in case they have any thoughts on working with P4 servers that do case-folding, or at least failing gracefully). On 29/04/15 00:01, Lex Spoon wrote: The last comment in the test took me a minute to decipher. I would suggest no repo path called LC instead of no

Re: [PATCH] git-p4: add failing tests for case-folding p4d

2015-04-28 Thread Lex Spoon
The last comment in the test took me a minute to decipher. I would suggest no repo path called LC instead of no repo called LC. Also, it would have helped me to either have a little comment on the UC version of the test, or to make the previous comment a little more neutral so that it will apply