Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability

2012-10-09 Thread Joachim Schmitz
Junio C Hamano wrote: Junio C Hamano gits...@pobox.com writes: Ben Walton bdwal...@gmail.com writes: Avoid a GNU-ism in the cp options used by t5400-send-pack. Change -a to -pR. Signed-off-by: Ben Walton bdwal...@gmail.com --- Thanks, but is -p essential for this test to pass, or can we

Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability

2012-10-08 Thread Junio C Hamano
Ben Walton bdwal...@gmail.com writes: Avoid a GNU-ism in the cp options used by t5400-send-pack. Change -a to -pR. Signed-off-by: Ben Walton bdwal...@gmail.com --- Thanks, but is -p essential for this test to pass, or can we get away with just -R? t/t5400-send-pack.sh | 2 +- 1 file

Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability

2012-10-08 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Ben Walton bdwal...@gmail.com writes: Avoid a GNU-ism in the cp options used by t5400-send-pack. Change -a to -pR. Signed-off-by: Ben Walton bdwal...@gmail.com --- Thanks, but is -p essential for this test to pass, or can we get away with just

Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability

2012-10-08 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Thanks, but is -p essential for this test to pass, or can we get away with just -R? Besides, when you spot a potential problem, please ask git grep to catch them all. In other words, how about doing this instead? -- 8 -- Subject: tests: cp -a is a

Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability

2012-10-08 Thread Ben Walton
On Mon, Oct 8, 2012 at 6:45 PM, Junio C Hamano gits...@pobox.com wrote: Junio C Hamano gits...@pobox.com writes: Thanks, but is -p essential for this test to pass, or can we get away with just -R? Besides, when you spot a potential problem, please ask git grep to catch them all. In other

Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability

2012-10-08 Thread Junio C Hamano
Ben Walton bdwal...@gmail.com writes: On Mon, Oct 8, 2012 at 6:45 PM, Junio C Hamano gits...@pobox.com wrote: Junio C Hamano gits...@pobox.com writes: Thanks, but is -p essential for this test to pass, or can we get away with just -R? Besides, when you spot a potential problem, please ask