Re: [PATCH] userdiff: add build-in pattern for shell

On Wed, Mar 29, 2017 at 11:25:15PM -0700, Junio C Hamano wrote: Pickfire writes: > +- `sh` suitable for source code in POSIX-compatible shells. The new test you added seems to show that this is not limited to POSIX shells but also understands bashisms like ${x//x/x}. Perhaps drop "POSIX-comp

Re: [PATCH] userdiff: add build-in pattern for shell

Pickfire writes: >> > +- `sh` suitable for source code in POSIX-compatible shells. >> >> The new test you added seems to show that this is not limited to >> POSIX shells but also understands bashisms like ${x//x/x}. Perhaps >> drop "POSIX-compatible" from here > > Those shells are still POSIX-c

Re: Re: [PATCH] userdiff: add build-in pattern for shell

Junio C Hamano wrote: > Ivan Tham writes: > > > Shell are widely used but comes with lots of different patterns. The > > build-in pattern aim for POSIX-compatible shells with some additions: > > > > - Notably ${g//re/s} and ${g#cut} > > - "function" from bash > > > > Signed-off-by: Ivan Tham >

Re: [PATCH] userdiff: add build-in pattern for shell

Ivan Tham writes: > Shell are widely used but comes with lots of different patterns. The > build-in pattern aim for POSIX-compatible shells with some additions: > > - Notably ${g//re/s} and ${g#cut} > - "function" from bash > > Signed-off-by: Ivan Tham > --- > Documentation/gitattributes.txt |