Re: [PATCH 0/3] fix test suite with mingw-unicode patches

2014-07-16 Thread Thomas Braun
Am 16.07.2014 11:29, schrieb Stepan Kasal: >> * t7001-mv: 6 >> cp -P fails in MinGW - perhaps use the long option forms (--no-dereference)? > > "cp -P" fails with our 2001-edition of cp, so msysgit had to revert: > https://github.com/msysgit/git/commit/6d3e23d4 > > But I was ashamed to mention th

Re: [PATCH 0/3] fix test suite with mingw-unicode patches

2014-07-16 Thread Stepan Kasal
Hello Karsten, thanks for your analysis. Most of the patches you refer to are simply switching off tests for MINGW; let me comment on the remaining ones: > * t0110-urlmatch-normalization: 1 > > Passing binary data on the command line...would have to > teach test-urlmatch-normalization.c to read

Re: [PATCH 0/3] fix test suite with mingw-unicode patches

2014-07-15 Thread Karsten Blees
Am 15.07.2014 20:20, schrieb Junio C Hamano: > Stepan Kasal writes: > >> Hello Hannes, >> attached please find the patches that Karsten pointed out: >> >> 1) The unicode file name support was omitted from his unicode patch >> series; my mistake, sorry. There is still big part missing: support >>

Re: [PATCH 0/3] fix test suite with mingw-unicode patches

2014-07-15 Thread Junio C Hamano
Stepan Kasal writes: > Hello Hannes, > attached please find the patches that Karsten pointed out: > > 1) The unicode file name support was omitted from his unicode patch > series; my mistake, sorry. There is still big part missing: support > for unicode environment; I can only hope the tests wou

Re: [PATCH 0/3] fix test suite with mingw-unicode patches

2014-07-15 Thread Stepan Kasal
Hello, I'm sorry that I have to reply to my own mail, but I forgot this: > Karsten Blees (2): > Win32: Unicode file name support (except dirent) .. has this one squashed in: Win32: fix detection of empty directories in is_dir_empty https://github.com/msysgit/git/commit/91db148 > Win32: Un