Re: [PATCH 02/14] builtin/repack: replace hard-coded constant

2018-10-09 Thread brian m. carlson
On Mon, Oct 08, 2018 at 07:01:27PM -0400, Eric Sunshine wrote: > On Mon, Oct 8, 2018 at 6:27 PM Stefan Beller wrote: > > On Mon, Oct 8, 2018 at 2:57 PM brian m. carlson > > wrote: > > > - if (line.len != 40) > > > - die("repack: Expecting 40 character sha1 line

Re: [PATCH 02/14] builtin/repack: replace hard-coded constant

2018-10-08 Thread Eric Sunshine
On Mon, Oct 8, 2018 at 6:27 PM Stefan Beller wrote: > On Mon, Oct 8, 2018 at 2:57 PM brian m. carlson > wrote: > > - if (line.len != 40) > > - die("repack: Expecting 40 character sha1 lines only > > from pack-objects."); > > + if (line.len != the

Re: [PATCH 02/14] builtin/repack: replace hard-coded constant

2018-10-08 Thread Stefan Beller
On Mon, Oct 8, 2018 at 2:57 PM brian m. carlson wrote: > > Signed-off-by: brian m. carlson > --- > builtin/repack.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/builtin/repack.c b/builtin/repack.c > index c6a7943d5c..e77859062d 100644 > --- a/builtin/repack.c > ++