Re: [PATCH 02/38] rename_ref_available(): add docstring

2016-06-09 Thread Junio C Hamano
Michael Haggerty writes: > I propose to change the parameter names to `old_refname` and > `new_refname` and to change the docstring to > ... > Does that sound good? Yes. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More m

Re: [PATCH 02/38] rename_ref_available(): add docstring

2016-06-09 Thread Michael Haggerty
On 06/07/2016 08:10 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> From: David Turner >> >> Signed-off-by: David Turner >> Signed-off-by: Junio C Hamano >> Signed-off-by: Michael Haggerty >> --- >> refs/refs-internal.h | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git

Re: [PATCH 02/38] rename_ref_available(): add docstring

2016-06-07 Thread Junio C Hamano
Michael Haggerty writes: > From: David Turner > > Signed-off-by: David Turner > Signed-off-by: Junio C Hamano > Signed-off-by: Michael Haggerty > --- > refs/refs-internal.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/refs/refs-internal.h b/refs/refs-internal.h > index efe58