Re: [PATCH 08/11] pack-objects: create pack v4 tables

2013-09-09 Thread Junio C Hamano
Nicolas Pitre writes: > Is anyone still using --max-pack-size ? > > I'm wondering if producing multiple packs from pack-objects is really > useful these days. If I remember correctly, this was created to allow > the archiving of large packs onto CDROMs or the like. I thought this was more abo

Re: [PATCH 08/11] pack-objects: create pack v4 tables

2013-09-09 Thread Nicolas Pitre
On Mon, 9 Sep 2013, Duy Nguyen wrote: > On Sun, Sep 8, 2013 at 10:04 PM, Nguyễn Thái Ngọc Duy > wrote: > > +static void prepare_sha1_table(void) > > +{ > > + unsigned i; > > + /* > > +* This table includes SHA-1s that may not be present in the > > +* pack. One of the

Re: [PATCH 08/11] pack-objects: create pack v4 tables

2013-09-09 Thread Duy Nguyen
On Sun, Sep 8, 2013 at 10:04 PM, Nguyễn Thái Ngọc Duy wrote: > +static void prepare_sha1_table(void) > +{ > + unsigned i; > + /* > +* This table includes SHA-1s that may not be present in the > +* pack. One of the use of such SHA-1 is for completing thin > +* pa