Re: [PATCH 1/1] commit-graph: fix UX issue when .lock file exists

2018-05-09 Thread Jeff King
On Wed, May 09, 2018 at 10:53:56AM -0400, Derrick Stolee wrote: > > Your cover letter is way longer than this description. Should some of > > that background perhaps go in the commit message? > > I did want a place to include the full die() message in the new behavior, > but that seemed like

Re: [PATCH 1/1] commit-graph: fix UX issue when .lock file exists

2018-05-09 Thread Derrick Stolee
On 5/9/2018 10:42 AM, Jeff King wrote: On Wed, May 09, 2018 at 02:15:38PM +, Derrick Stolee wrote: The commit-graph file lives in the .git/objects/info directory. Previously, a failure to acquire the commit-graph.lock file was assumed to be due to the lack of the info directory, so a

Re: [PATCH 1/1] commit-graph: fix UX issue when .lock file exists

2018-05-09 Thread Jeff King
On Wed, May 09, 2018 at 02:15:38PM +, Derrick Stolee wrote: > The commit-graph file lives in the .git/objects/info directory. > Previously, a failure to acquire the commit-graph.lock file was > assumed to be due to the lack of the info directory, so a mkdir() > was called. This gave incorrect