Re: [PATCH 2/2] setup.c: re-fix d95138e (setup: set env $GIT_WORK_TREE when ..

2015-12-07 Thread Junio C Hamano
Duy Nguyen writes: > On Thu, Dec 3, 2015 at 7:17 PM, Nguyễn Thái Ngọc Duy > wrote: >> The solution in d95138e is reverted in this commit. Instead we reuse the >> solution from c056261 [4]. c056261 fixes another setup-messed-up-by-alias >> by saving and restoring env for git-clone and git-init.

Re: [PATCH 2/2] setup.c: re-fix d95138e (setup: set env $GIT_WORK_TREE when ..

2015-12-05 Thread Duy Nguyen
On Thu, Dec 3, 2015 at 7:17 PM, Nguyễn Thái Ngọc Duy wrote: > The solution in d95138e is reverted in this commit. Instead we reuse the > solution from c056261 [4]. c056261 fixes another setup-messed-up-by-alias > by saving and restoring env for git-clone and git-init. Now I conclude > that setup-m

Re: [PATCH 2/2] setup.c: re-fix d95138e (setup: set env $GIT_WORK_TREE when ..

2015-12-04 Thread Duy Nguyen
On Fri, Dec 4, 2015 at 9:35 PM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> ... Now I conclude >> that setup-messed-by-alias is always evil. So the env restoration is >> done for _all_ commands whenever aliases are involved. > > So a side effect of this is whenever an alias is inv

Re: [PATCH 2/2] setup.c: re-fix d95138e (setup: set env $GIT_WORK_TREE when ..

2015-12-04 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > ... Now I conclude > that setup-messed-by-alias is always evil. So the env restoration is > done for _all_ commands whenever aliases are involved. So a side effect of this is whenever an alias is involved, all commands are re-spawned, not just the external ones b