Re: [PATCH 3/4] hook: add signature using "interpret-trailers"

Note: Re-attempting to send mail due to rejection On Mon, 2017-07-10 at 16:13 +0100, Ramsay Jones wrote: > > Again, s/signature/sign-off/g, or similar (including subject line). > Thanks! Forgot that in the course of splitting the patches and modifying them. -- Kaartic

Re: [PATCH 3/4] hook: add signature using "interpret-trailers"

On Mon, 2017-07-10 at 16:13 +0100, Ramsay Jones wrote: > > Again, s/signature/sign-off/g, or similar (including subject line). > Thanks! Forgot that in the course of splitting the patches and modifying them.

Re: [PATCH 3/4] hook: add signature using "interpret-trailers"

Ramsay Jones writes: >> It works well in all cases except when the user invokes >> "git commit" without any arguments. In that case manually >> add a new line after the first line to ensure it's consistent >> with the output of "-s" option. >> > > Again,

Re: [PATCH 3/4] hook: add signature using "interpret-trailers"

On 10/07/17 15:17, Kaartic Sivaraam wrote: > The sample hook to prepare the commit message before > a commit allows users to opt-in to add the signature > to the commit message. The signature is added at a place > that isn't consistent with the "-s" option of "git commit". > Further, it could go