Hi Junio,
On Mon, 30 Oct 2017, Junio C Hamano wrote:
> Jonathan Nieder writes:
>
> > I have other changes to make when rerolling anyway (from Junio's
> > review), so no need for a followup patch. Will fix this in the
> > reroll today.
> >
> > Thanks for catching and
Jonathan Nieder writes:
> I have other changes to make when rerolling anyway (from Junio's
> review), so no need for a followup patch. Will fix this in the
> reroll today.
>
> Thanks for catching and diagnosing this, Dscho!
In the meantime, I've queued this from Dscho;
Hi,
Stefan Beller wrote:
> On Wed, Oct 25, 2017 at 5:51 AM, Johannes Schindelin
> wrote:
>> This breaks on Windows. And it is not immediately obvious how so, so let
>> me explain:
[nice explanation snipped]
>> As a consequence, the test fails. Could you please squash
On Wed, Oct 25, 2017 at 5:51 AM, Johannes Schindelin
wrote:
> Hi Jonathan,
>
> [I only saw that you replied to 3/5 with v2 after writing this reply, but
> it would apply to v2's 3/5, too]
>
> On Mon, 23 Oct 2017, Jonathan Nieder wrote:
>
>> diff --git
Hi Jonathan,
[I only saw that you replied to 3/5 with v2 after writing this reply, but
it would apply to v2's 3/5, too]
On Mon, 23 Oct 2017, Jonathan Nieder wrote:
> diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh
> index 86811a0c35..fd94dd40d2 100755
> --- a/t/t5601-clone.sh
> +++
Jonathan Nieder writes:
> 1. First, check whether $GIT_SSH supports OpenSSH options by running
>
> $GIT_SSH -G
>
> This returns status 0 and prints configuration in OpenSSH if it
> recognizes all and returns status 255 if it encounters
> an unrecognized
>> This is the main one. Simplified by making "auto" behave the same as
>> unset.
>
> I still don't see the benefit of allowing a user to explicitly set
> 'auto' then, if setting it to 'auto' is effectively a noop. But maybe
> there's something I'm not seeing.
>
If /etc/gitconfig says SSH, and
On 10/23, Jonathan Nieder wrote:
> Android's "repo" tool is a tool for managing a large codebase
> consisting of multiple smaller repositories, similar to Git's
> submodule feature. Starting with Git 94b8ae5a (ssh: introduce a
> 'simple' ssh variant, 2017-10-16), users noticed that it stopped
>
Brandon Williams wrote:
> On 10/23, Jonathan Nieder wrote:
>> Separately from how to document it, what do you think a good behavior
>> would be? Should the "auto" configuration trigger command line based
>> detection just like no configuration at all? Should the "auto" value
>> for
On Mon, 23 Oct 2017 15:51:06 -0700
Brandon Williams wrote:
> On 10/23, Jonathan Nieder wrote:
> > Separately from how to document it, what do you think a good behavior
> > would be? Should the "auto" configuration trigger command line based
> > detection just like no
Stefan Beller wrote:
> On Mon, Oct 23, 2017 at 2:31 PM, Jonathan Nieder wrote:
>> 1. First, check whether $GIT_SSH supports OpenSSH options by running
>>
>> $GIT_SSH -G
>>
>> This returns status 0 and prints configuration in OpenSSH if it
>> recognizes all
On 10/23, Jonathan Nieder wrote:
> Hi,
>
> Jonathan Tan wrote:
>
> > The new documentation seems to imply that setting ssh.variant (or
> > GIT_SSH_VARIANT) to "auto" is equivalent to not setting it at all, but
> > looking at the code, it doesn't seem to be the case (not setting it at
> > all
Hi,
Jonathan Tan wrote:
> The new documentation seems to imply that setting ssh.variant (or
> GIT_SSH_VARIANT) to "auto" is equivalent to not setting it at all, but
> looking at the code, it doesn't seem to be the case (not setting it at
> all invokes checking the first word of core.sshCommand,
On Mon, Oct 23, 2017 at 2:31 PM, Jonathan Nieder wrote:
> 1. First, check whether $GIT_SSH supports OpenSSH options by running
>
> $GIT_SSH -G
>
> This returns status 0 and prints configuration in OpenSSH if it
> recognizes all and returns status 255 if it
On Mon, 23 Oct 2017 14:31:59 -0700
Jonathan Nieder wrote:
> @@ -2083,14 +2083,19 @@ visited as a result of a redirection do not
> participate in matching.
> ssh.variant::
> Depending on the value of the environment variables `GIT_SSH` or
> `GIT_SSH_COMMAND`, or
15 matches
Mail list logo