Re: [PATCH 4/4] pretty-print: add --pretty=noexpand

2016-03-19 Thread Linus Torvalds
On Thu, Mar 17, 2016 at 10:08 PM, Jeff King wrote: > > Hmm. Isn't "expand tabs" orthogonal to the rest of the pretty format? > That is, couldn't one want "--pretty=fuller, but with tabs expanded"? Yeah, you are right, one easily could. And in fact I end up doing "fuller" myself occasionally, beca

Re: [PATCH 4/4] pretty-print: add --pretty=noexpand

2016-03-19 Thread Junio C Hamano
Jeff King writes: > E.g., start with: > > - only CMIT_FMT_MEDIUM expands tabs (and does so by default) > > - passing --no-expand-tabs suppresses this behavior > > - passing --expand-tabs is an error for now; if people care later, > they can add support for other formats (naively this is

Re: [PATCH 4/4] pretty-print: add --pretty=noexpand

2016-03-19 Thread Junio C Hamano
Linus Torvalds writes: > On Thu, Mar 17, 2016 at 4:16 PM, Junio C Hamano wrote: >> It is reasonable for tweak the default output mode for "git log" to >> untabify the commit log message, it sometimes may be necessary to >> see the output without tab expansion. > > Thanks, these all look good to

Re: [PATCH 4/4] pretty-print: add --pretty=noexpand

2016-03-19 Thread Jeff King
On Thu, Mar 17, 2016 at 10:36:16PM -0700, Linus Torvalds wrote: > On Thu, Mar 17, 2016 at 10:08 PM, Jeff King wrote: > > > > Hmm. Isn't "expand tabs" orthogonal to the rest of the pretty format? > > That is, couldn't one want "--pretty=fuller, but with tabs expanded"? > > Yeah, you are right, on

Re: [PATCH 4/4] pretty-print: add --pretty=noexpand

2016-03-19 Thread Jeff King
On Thu, Mar 17, 2016 at 04:16:21PM -0700, Junio C Hamano wrote: > It is reasonable for tweak the default output mode for "git log" to > untabify the commit log message, it sometimes may be necessary to > see the output without tab expansion. > > Invent a new --pretty option to do this. Use this

Re: [PATCH 4/4] pretty-print: add --pretty=noexpand

2016-03-19 Thread Linus Torvalds
On Thu, Mar 17, 2016 at 4:16 PM, Junio C Hamano wrote: > It is reasonable for tweak the default output mode for "git log" to > untabify the commit log message, it sometimes may be necessary to > see the output without tab expansion. Thanks, these all look good to me. Sorry for not following up,