Re: [PATCH 4/4] sequencer: use trailer's trailer layout

2016-11-01 Thread Junio C Hamano
Jonathan Tan writes: >>> 9:I want to mention about Signed-off-by: here. >> ... >> This seems a bit weird. > > This is because the "I want to mention" block has 100% trailer lines > (since its only line contains a colon). We could forbid spaces in > trailer field names,

Re: [PATCH 4/4] sequencer: use trailer's trailer layout

2016-11-01 Thread Jonathan Tan
On 10/31/2016 06:11 PM, Junio C Hamano wrote: Jonathan Tan writes: diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh index ba4902d..635b394 100755 --- a/t/t4014-format-patch.sh +++ b/t/t4014-format-patch.sh @@ -1277,8 +1277,7 @@ EOF 4:Subject: [PATCH]

Re: [PATCH 4/4] sequencer: use trailer's trailer layout

2016-10-31 Thread Junio C Hamano
Jonathan Tan writes: > @@ -26,30 +27,6 @@ static GIT_PATH_FUNC(git_path_opts_file, SEQ_OPTS_FILE) > static GIT_PATH_FUNC(git_path_seq_dir, SEQ_DIR) > static GIT_PATH_FUNC(git_path_head_file, SEQ_HEAD_FILE) > > -static int is_rfc2822_line(const char *buf, int len) >