Re: [PATCH 5/5] git-diff.txt: fix ordering of the [--no-index] form

2013-04-24 Thread Ramkumar Ramachandra
Jonathan Nieder wrote: > What would that configuration variable even mean? "Set this to make > other people's scripts work when they assume --no-index won't be > triggered automatically"? No. "Set this for interactive use". -- To unsubscribe from this list: send the line "unsubscribe git" in the

Re: [PATCH 5/5] git-diff.txt: fix ordering of the [--no-index] form

2013-04-24 Thread Jonathan Nieder
Ramkumar Ramachandra wrote: > I completely disagree, but we don't have to agree: make it a > configuration variable. I thought we had discussed before how every configuration variable costs quite a lot in terms of Git's teachability. What would that configuration variable even mean? "Set this t

Re: [PATCH 5/5] git-diff.txt: fix ordering of the [--no-index] form

2013-04-24 Thread Ramkumar Ramachandra
Jonathan Nieder wrote: > * hard to document > [...] I completely disagree, but we don't have to agree: make it a configuration variable. Even if it's turned to "never" by default, I don't mind having one extra line in my .gitconfig. But you went all "Oh please no" when I brought it up. I thoug

Re: [PATCH 5/5] git-diff.txt: fix ordering of the [--no-index] form

2013-04-24 Thread Jonathan Nieder
Ramkumar Ramachandra wrote: > Jonathan Nieder wrote: >> Because typing paths does not make my intent perfectly clear. > > I'm not able to understand this. Doesn't your prompt tell you which > directory you're in, and if you're in a git repository? When you type > out paths, you know what is insi

Re: [PATCH 5/5] git-diff.txt: fix ordering of the [--no-index] form

2013-04-24 Thread Ramkumar Ramachandra
Jonathan Nieder wrote: > Because typing paths does not make my intent perfectly clear. I'm not able to understand this. Doesn't your prompt tell you which directory you're in, and if you're in a git repository? When you type out paths, you know what is inside and what is outside your repository.

Re: [PATCH 5/5] git-diff.txt: fix ordering of the [--no-index] form

2013-04-24 Thread Jonathan Nieder
Ramkumar Ramachandra wrote: > Jonathan Nieder wrote: >> Oh please no. > > If I understand this correctly, you are horrified by this? > https://github.com/artagnon/dotfiles/blob/master/.gitconfig#L30 Nope, that looks like a useful way to save typing, and "git help" helpfully expands any of your cu

Re: [PATCH 5/5] git-diff.txt: fix ordering of the [--no-index] form

2013-04-24 Thread Ramkumar Ramachandra
Jonathan Nieder wrote: > Oh please no. If I understand this correctly, you are horrified by this? https://github.com/artagnon/dotfiles/blob/master/.gitconfig#L30 By the way, my zsh aliases git to g. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majo

Re: [PATCH 5/5] git-diff.txt: fix ordering of the [--no-index] form

2013-04-24 Thread Jonathan Nieder
Ramkumar Ramachandra wrote: > Jonathan Nieder wrote: >> Maybe it would make sense to move towards eliminating the "implicit >> --no-index for paths outside the repository" trick. I use "git diff >> --no-index" all the time, but I always spell it out to be careful. > > Huh? Why do you want to end

Re: [PATCH 5/5] git-diff.txt: fix ordering of the [--no-index] form

2013-04-24 Thread Ramkumar Ramachandra
Jonathan Nieder wrote: > Maybe it would make sense to move towards eliminating the "implicit > --no-index for paths outside the repository" trick. I use "git diff > --no-index" all the time, but I always spell it out to be careful. Huh? Why do you want to endure the pain of spelling it out, when

Re: [PATCH 5/5] git-diff.txt: fix ordering of the [--no-index] form

2013-04-24 Thread Jonathan Nieder
Ramkumar Ramachandra wrote: > The form is a special case of > the first form where the number of paths are limited to two. Besides, > isn't that how the DESCRIPTION section explains it now? Sort of. It's a completely different form, but when --no-index i

Re: [PATCH 5/5] git-diff.txt: fix ordering of the [--no-index] form

2013-04-24 Thread Ramkumar Ramachandra
Junio C Hamano wrote: > The "--no-index" mode was a hack to allow "git diff" goodies to be > used outside the context of "git", and a proper execution of it > should have been to send patches to GNU or BSD diff maintainers, not > to add the "--no-index" option that is unrelated to "git" to our > co

Re: [PATCH 5/5] git-diff.txt: fix ordering of the [--no-index] form

2013-04-24 Thread Junio C Hamano
Ramkumar Ramachandra writes: > The SYNOPSIS lists the [--no-index] form as the last item, but the > DESCRIPTION lists it as a natural extension of the first form. Perhaps either the description or your reading is wrong. The "--no-index" mode was a hack to allow "git diff" goodies to be used out