Re: [PATCH v2] .clang-format: introduce the use of clang-format

On Wed, Jan 21, 2015 at 04:28:00PM -0500, Ramkumar Ramachandra wrote: > > So overall I think it has some promise, but I do not think it is quite > > flexible enough yet for us to use day-to-day. > > The big negative is that it will probably never be. I'll try to look > at the larger issues later

Re: [PATCH v2] .clang-format: introduce the use of clang-format

Jeff King wrote: > On Wed, Jan 21, 2015 at 12:01:27PM -0500, Ramkumar Ramachandra wrote: >> +BreakBeforeBraces: Linux >> [...] >> +BreakBeforeBraces: Stroustrup Oh, oops. > - It really wants to break function declarations that go over the >column limit, even though we often do not do so. I t

Re: [PATCH v2] .clang-format: introduce the use of clang-format

On Wed, Jan 21, 2015 at 12:01:27PM -0500, Ramkumar Ramachandra wrote: > Instead of manually eyeballing style in reviews, just ask all > contributors to run their patches through [git-]clang-format. Thanks for mentioning this; I hadn't seen the tool before. I didn't see it mentioned here, but for