Re: [PATCH v2] enter_repo(): fix docs to match code

2015-03-31 Thread Junio C Hamano
Jeff King p...@peff.net writes: I'm not sure that's true. The precedence changed, and the is it valid check changed. Yeah, I must have misread the review thread. I only noticed that the postimage does not have any lines that v1 changed from the original, but at the word level there indeed are

Re: [PATCH v2] enter_repo(): fix docs to match code

2015-03-31 Thread Junio C Hamano
Paul Tan pyoka...@gmail.com writes: On Mon, Mar 30, 2015 at 07:44:08AM -0400, Jeff King wrote: Yes, this was adjusted in b3256eb (standardize and improve lookup rules for external local repos, 2012-02-02), but I failed to update the comment. Your patch is certainly an improvement, but I

Re: [PATCH v2] enter_repo(): fix docs to match code

2015-03-31 Thread Jeff King
On Tue, Mar 31, 2015 at 10:35:56AM -0700, Junio C Hamano wrote: In b3256eb (standardize and improve lookup rules for external local repos), enter_repo() was modified to use a different precedence ordering of suffixes for DWIM of the repository path, and to ensure that the repository path