Re: [PATCH v2] remove the impression of unexpectedness when access is denied

2013-05-03 Thread Jonathan Nieder
Hi, Heiko Voigt wrote: > --- a/connect.c > +++ b/connect.c > @@ -49,6 +49,16 @@ static void add_extra_have(struct extra_have_objects > *extra, unsigned char *sha1 > extra->nr++; > } > > +static void die_initial_contact(int got_at_least_one_head) > +{ > + if (got_at_least_one_head) >

Re: [PATCH v2] remove the impression of unexpectedness when access is denied

2013-05-06 Thread Junio C Hamano
Jonathan Nieder writes: > I ran into this message for the first time today. > > $ git fetch --all > Fetching origin > remote: Counting objects: 368, done. > [...] > Fetching gitk > fatal: Could not read from remote repository. > > Please make sure you have the correct access rights > and t

Re: [PATCH v2] remove the impression of unexpectedness when access is denied

2013-05-07 Thread Jeff King
On Mon, May 06, 2013 at 07:02:41AM -0700, Junio C Hamano wrote: > >Would it make sense for the server to send an "ERR" packet to give > >a more helpful diagnosis? > > I think git-daemon does so (or at least attempts to do so); > path_ok() uses enter_repo() to check if the given path is a