Re: [PATCH v2 1/1] contrib: add coverage-diff script

2018-09-13 Thread Derrick Stolee
On 9/13/2018 1:40 PM, Junio C Hamano wrote: "Derrick Stolee via GitGitGadget" writes: + then + line_num=$(($line_num + 1)) + fi + fi + done I have a feeling that a single Perl script instead of a shel

Re: [PATCH v2 1/1] contrib: add coverage-diff script

2018-09-13 Thread Eric Sunshine
On Thu, Sep 13, 2018 at 10:56 AM Derrick Stolee via GitGitGadget wrote: > There have been a few bugs in recent patches what would have been caught > if the test suite covered those blocks (including a few of mine). I want > to work towards a "sensible" amount of coverage on new topics. In my opini

Re: [PATCH v2 1/1] contrib: add coverage-diff script

2018-09-13 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > From: Derrick Stolee > > We have coverage targets in our Makefile for using gcov to display line > coverage based on our test suite. The way I like to do it is to run: > > make coverage-test > make coverage-report > > This leaves the repo in a