Re: [PATCH v2 14/14] commit.h: delete 'util' field in struct commit

On Mon, May 14, 2018 at 8:14 PM, Derrick Stolee wrote: > I disagree with the removal of "generation". My intention is to make the > commit-graph feature a standard feature that most repos (of reasonable size) > want to have. In that case, 'graph_pos' and 'generation' will be set

Re: [PATCH v2 14/14] commit.h: delete 'util' field in struct commit

On 5/14/2018 1:30 PM, Duy Nguyen wrote: On Mon, May 14, 2018 at 6:07 PM, Duy Nguyen wrote: On Mon, May 14, 2018 at 04:52:29PM +0900, Junio C Hamano wrote: Nguyễn Thái Ngọc Duy writes: diff --git a/commit.h b/commit.h index 838f6a6b26..70371e111e

Re: [PATCH v2 14/14] commit.h: delete 'util' field in struct commit

On Mon, May 14, 2018 at 6:07 PM, Duy Nguyen wrote: > On Mon, May 14, 2018 at 04:52:29PM +0900, Junio C Hamano wrote: >> Nguyễn Thái Ngọc Duy writes: >> >> > diff --git a/commit.h b/commit.h >> > index 838f6a6b26..70371e111e 100644 >> > --- a/commit.h >> >

Re: [PATCH v2 14/14] commit.h: delete 'util' field in struct commit

On Mon, May 14, 2018 at 04:52:29PM +0900, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > > > diff --git a/commit.h b/commit.h > > index 838f6a6b26..70371e111e 100644 > > --- a/commit.h > > +++ b/commit.h > > @@ -18,12 +18,16 @@ struct commit_list { > > > > struct

Re: [PATCH v2 14/14] commit.h: delete 'util' field in struct commit

Nguyễn Thái Ngọc Duy writes: > diff --git a/commit.h b/commit.h > index 838f6a6b26..70371e111e 100644 > --- a/commit.h > +++ b/commit.h > @@ -18,12 +18,16 @@ struct commit_list { > > struct commit { > struct object object; > - void *util; > unsigned int