Re: [PATCH v2 2/2] Be more careful when determining whether a remote was configured

2017-01-19 Thread Jeff King
On Thu, Jan 19, 2017 at 10:20:02PM +0100, Johannes Schindelin wrote: > There is only one caller of remote_is_configured() (in `git fetch`) that > may want to take remotes into account even if they were configured > outside the repository config; all other callers essentially try to > prevent the G

Re: [PATCH v2 2/2] Be more careful when determining whether a remote was configured

2017-01-19 Thread Johannes Schindelin
Hi Peff, On Thu, 19 Jan 2017, Jeff King wrote: > diff --git a/builtin/fetch.c b/builtin/fetch.c > index c85f3471d..9024cfffa 100644 > --- a/builtin/fetch.c > +++ b/builtin/fetch.c > @@ -1014,9 +1014,9 @@ static int add_remote_or_group(const char *name, struct > string_list *list) > git_con

Re: [PATCH v2 2/2] Be more careful when determining whether a remote was configured

2017-01-19 Thread Junio C Hamano
Jeff King writes: > I'm trying to figure out why "fetch --multiple" wouldn't just take a url > in the first place. I guess it is because multiple fetch is useless > without refspecs (since otherwise you're just writing to FETCH_HEAD, > which gets immediately overwritten). This is probably a tang

Re: [PATCH v2 2/2] Be more careful when determining whether a remote was configured

2017-01-19 Thread Jeff King
On Thu, Jan 19, 2017 at 01:45:29PM -0800, Junio C Hamano wrote: > Jeff King writes: > > > I'm trying to figure out why "fetch --multiple" wouldn't just take a url > > in the first place. I guess it is because multiple fetch is useless > > without refspecs (since otherwise you're just writing to