Jeff King writes:
> So I think on the generating side we are better off creating a slightly
> longer abbreviation that is unambiguous no matter what context it is
> used in. I.e., I'd argue that it's actually more _correct_ to ignore
> the disambiguation code entirely on the
On Wed, Oct 04, 2017 at 03:07:25PM +0900, Junio C Hamano wrote:
> > - exists = has_sha1_file(sha1);
> > - while (len < GIT_SHA1_HEXSZ) {
> > - struct object_id oid_ret;
> > - status = get_short_oid(hex, len, _ret, GET_OID_QUIETLY);
> > - if (exists
> > -
Derrick Stolee writes:
> On 10/4/2017 2:07 AM, Junio C Hamano wrote:
>> Derrick Stolee writes:
>>
>>> - exists = has_sha1_file(sha1);
>>> - while (len < GIT_SHA1_HEXSZ) {
>>> - struct object_id oid_ret;
>>> - status =
On 10/4/2017 2:07 AM, Junio C Hamano wrote:
Derrick Stolee writes:
- exists = has_sha1_file(sha1);
- while (len < GIT_SHA1_HEXSZ) {
- struct object_id oid_ret;
- status = get_short_oid(hex, len, _ret, GET_OID_QUIETLY);
-
On 10/4/2017 2:10 AM, Junio C Hamano wrote:
Derrick Stolee writes:
...
I understand that this patch on its own does not have good numbers. I
split the
patches 3 and 4 specifically to highlight two distinct changes:
Patch 3: Unroll the len loop that may inspect all files
Derrick Stolee writes:
> On 10/3/2017 6:49 AM, Junio C Hamano wrote:
>> Derrick Stolee writes:
>>
>>> p0008.1: find_unique_abbrev() for existing objects
>>> --
>>>
>>> For 10 repeated tests, each checking
Derrick Stolee writes:
> -int find_unique_abbrev_r(char *hex, const unsigned char *sha1, int len)
> +struct min_abbrev_data {
> + unsigned int init_len;
> + unsigned int cur_len;
> + char *hex;
> +};
> +
> +static int extend_abbrev_len(const struct object_id
On 10/3/2017 6:49 AM, Junio C Hamano wrote:
Derrick Stolee writes:
p0008.1: find_unique_abbrev() for existing objects
--
For 10 repeated tests, each checking 100,000 known objects, we find the
following results when
Derrick Stolee writes:
> p0008.1: find_unique_abbrev() for existing objects
> --
>
> For 10 repeated tests, each checking 100,000 known objects, we find the
> following results when running in a Linux VM:
>
> | | Pack
9 matches
Mail list logo