Re: [PATCH v7 2/3] worktree: move/refactor find_shared_symref from branch.c

2015-09-21 Thread Eric Sunshine
On Wed, Sep 16, 2015 at 5:36 PM, Mike Rappazzo wrote: > On Wed, Sep 16, 2015 at 5:09 PM, Eric Sunshine > wrote: >> On Mon, Sep 14, 2015 at 1:44 PM, Mike Rappazzo wrote: >>> On Sat, Sep 12, 2015 at 11:19 PM, Eric Sunshine

Re: [PATCH v7 2/3] worktree: move/refactor find_shared_symref from branch.c

2015-09-16 Thread Eric Sunshine
On Mon, Sep 14, 2015 at 1:44 PM, Mike Rappazzo wrote: > On Sat, Sep 12, 2015 at 11:19 PM, Eric Sunshine > wrote: >> On Fri, Sep 4, 2015 at 5:39 PM, Michael Rappazzo wrote: >>> + while (!matched && worktree_list) { >>> +

Re: [PATCH v7 2/3] worktree: move/refactor find_shared_symref from branch.c

2015-09-16 Thread Mike Rappazzo
On Wed, Sep 16, 2015 at 5:09 PM, Eric Sunshine wrote: > On Mon, Sep 14, 2015 at 1:44 PM, Mike Rappazzo wrote: >> On Sat, Sep 12, 2015 at 11:19 PM, Eric Sunshine >> wrote: >>> On Fri, Sep 4, 2015 at 5:39 PM, Michael Rappazzo

Re: [PATCH v7 2/3] worktree: move/refactor find_shared_symref from branch.c

2015-09-14 Thread Mike Rappazzo
On Sat, Sep 12, 2015 at 11:19 PM, Eric Sunshine wrote: > On Fri, Sep 4, 2015 at 5:39 PM, Michael Rappazzo wrote: >> The code formerly in branch.c was largely the basis of the >> get_worktree_list implementation is now moved to worktree.c, >> and the

Re: [PATCH v7 2/3] worktree: move/refactor find_shared_symref from branch.c

2015-09-12 Thread Eric Sunshine
On Fri, Sep 4, 2015 at 5:39 PM, Michael Rappazzo wrote: > The code formerly in branch.c was largely the basis of the > get_worktree_list implementation is now moved to worktree.c, > and the find_shared_symref implementation has been refactored > to use get_worktree_list Some

Re: [PATCH v7 2/3] worktree: move/refactor find_shared_symref from branch.c

2015-09-11 Thread Junio C Hamano
Michael Rappazzo writes: > The code formerly in branch.c was largely the basis of the > get_worktree_list implementation is now moved to worktree.c, > and the find_shared_symref implementation has been refactored > to use get_worktree_list > > Signed-off-by: Michael Rappazzo

Re: [PATCH v7 2/3] worktree: move/refactor find_shared_symref from branch.c

2015-09-11 Thread Eric Sunshine
On Fri, Sep 11, 2015 at 5:52 PM, Junio C Hamano wrote: > Mike Rappazzo writes: >> On Fri, Sep 11, 2015 at 12:16 PM, Junio C Hamano wrote: >>> Michael Rappazzo writes: The code formerly in branch.c was largely

Re: [PATCH v7 2/3] worktree: move/refactor find_shared_symref from branch.c

2015-09-11 Thread Mike Rappazzo
On Fri, Sep 11, 2015 at 12:16 PM, Junio C Hamano wrote: > Michael Rappazzo writes: > >> The code formerly in branch.c was largely the basis of the >> get_worktree_list implementation is now moved to worktree.c, >> and the find_shared_symref implementation

Re: [PATCH v7 2/3] worktree: move/refactor find_shared_symref from branch.c

2015-09-11 Thread Junio C Hamano
Mike Rappazzo writes: > On Fri, Sep 11, 2015 at 12:16 PM, Junio C Hamano wrote: >> Michael Rappazzo writes: >> >>> The code formerly in branch.c was largely the basis of the >>> get_worktree_list implementation is now moved to

Re: [PATCH v7 2/3] worktree: move/refactor find_shared_symref from branch.c

2015-09-11 Thread Mike Rappazzo
On Fri, Sep 11, 2015 at 7:10 PM, Eric Sunshine wrote: > On Fri, Sep 11, 2015 at 5:52 PM, Junio C Hamano wrote: > > Thanks for bringing this up. I haven't found a sufficient block of > time yet to review these patches, however, I had the same thought