Re: Reviews on mailing-list

2012-11-13 Thread Nguyen Thai Ngoc Duy
On Mon, Nov 12, 2012 at 4:15 AM, David Lang wrote: > Using a web browser requires connectivity at the time you are doing the > review. > > Mailing list based reviews can be done at times when you don't have > connectivity. I am not against email-based reviews but I'd like to point out that with G

Re: Reviews on mailing-list

2012-11-11 Thread David Lang
On Sun, 11 Nov 2012, Deniz Türkoglu wrote: I understand from the feedback that gerrit should get better on making it possible to review code via e-mail, as pointed out in Nguyen's mail, a flow like Shawn mentioned[1] can be a good solution. FWIW, I can fetch the change(s) from gerrit I am inter

Re: Reviews on mailing-list

2012-11-11 Thread Deniz Türkoglu
I understand from the feedback that gerrit should get better on making it possible to review code via e-mail, as pointed out in Nguyen's mail, a flow like Shawn mentioned[1] can be a good solution. FWIW, I can fetch the change(s) from gerrit I am interested in and review it any time I want. I curr

Re: Reviews on mailing-list

2012-11-11 Thread David Lang
On Sun, 11 Nov 2012, Krzysztof Mazur wrote: On Sun, Nov 11, 2012 at 11:09:36AM -0200, Thiago Farina wrote: On Sun, Nov 11, 2012 at 10:14 AM, Felipe Contreras wrote: Requiring everyone to use a web browser would limit the amount of ways people can review patches. I don't see that as a limitat

Re: Reviews on mailing-list

2012-11-11 Thread Krzysztof Mazur
On Sun, Nov 11, 2012 at 11:09:36AM -0200, Thiago Farina wrote: > On Sun, Nov 11, 2012 at 10:14 AM, Felipe Contreras > wrote: > > Requiring everyone to use a web browser would limit the amount of ways > > people can review patches. > I don't see that as a limitation as I think everyone has access t

Re: Reviews on mailing-list

2012-11-11 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 2:09 PM, Thiago Farina wrote: > On Sun, Nov 11, 2012 at 10:14 AM, Felipe Contreras > wrote: >> Requiring everyone to use a web browser would limit the amount of ways >> people can review patches. > I don't see that as a limitation as I think everyone has access to a > web

Re: Reviews on mailing-list

2012-11-11 Thread Thiago Farina
On Sun, Nov 11, 2012 at 10:14 AM, Felipe Contreras wrote: > Requiring everyone to use a web browser would limit the amount of ways > people can review patches. I don't see that as a limitation as I think everyone has access to a web browser these days, don't have? >> How come that can >> be an im

Re: Reviews on mailing-list

2012-11-11 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 2:28 AM, Deniz Türkoglu wrote: > On Sat, Nov 10, 2012 at 3:40 PM, Felipe Contreras > wrote: >> On Sun, Nov 11, 2012 at 12:19 AM, Deniz Türkoglu wrote: >> >>> This is my first mail to the git mailing list. I have been following >>> the list for some time now and I would li

Re: Reviews on mailing-list

2012-11-11 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 2:13 AM, Thiago Farina wrote: > On Sat, Nov 10, 2012 at 9:40 PM, Felipe Contreras >> Personally I think reviews on the mailing list is far superior than >> any other review methods. I've even blogged about it and all the >> reasons[1]. Gerrit is better than bugzilla, but i

Re: Reviews on mailing-list

2012-11-11 Thread Nguyen Thai Ngoc Duy
On Sun, Nov 11, 2012 at 6:11 PM, suvayu ali wrote: > I'm just a user, I found this discussion intriguing and was wondering if > any of you have heard of patchwork server[1]. It is a patch aggregator > for mailing lists and provides a convenient bug tracker like web > interface without getting in

Re: Reviews on mailing-list

2012-11-11 Thread suvayu ali
Hi, On Sun, Nov 11, 2012 at 2:13 AM, Thiago Farina wrote: > On Sat, Nov 10, 2012 at 9:40 PM, Felipe Contreras > wrote: >> On Sun, Nov 11, 2012 at 12:19 AM, Deniz Türkoglu wrote: >> >>> This is my first mail to the git mailing list. I have been following >>> the list for some time now and I woul

Re: Reviews on mailing-list

2012-11-10 Thread Ramkumar Ramachandra
Deniz Türkoglu wrote: > I have spoken to Shawn Pearce (gerrit project lead, google) and he > said he is OK with hosting the gerrit instance. > > I would like to hear your thoughts on this. I personally think email is by far the best interface for patches, reviews, and discussions. Git patches are

Re: Reviews on mailing-list

2012-11-10 Thread Junio C Hamano
Thiago Farina wrote: >Requiring a web browser is a huge requirement, ham?? No, but requiring reviews and discussions typed in the browser is. Pardon terseness, typo and HTML from a tablet. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@

Re: Reviews on mailing-list

2012-11-10 Thread Deniz Türkoglu
On Sat, Nov 10, 2012 at 3:40 PM, Felipe Contreras wrote: > On Sun, Nov 11, 2012 at 12:19 AM, Deniz Türkoglu wrote: > >> This is my first mail to the git mailing list. I have been following >> the list for some time now and I would like to suggest moving the >> reviews out of the mailing list, for

Re: Reviews on mailing-list

2012-11-10 Thread Thiago Farina
On Sat, Nov 10, 2012 at 9:40 PM, Felipe Contreras wrote: > On Sun, Nov 11, 2012 at 12:19 AM, Deniz Türkoglu wrote: > >> This is my first mail to the git mailing list. I have been following >> the list for some time now and I would like to suggest moving the >> reviews out of the mailing list, for

Re: Reviews on mailing-list

2012-11-10 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 12:19 AM, Deniz Türkoglu wrote: > This is my first mail to the git mailing list. I have been following > the list for some time now and I would like to suggest moving the > reviews out of the mailing list, for example to a gerrit instance, I > believe it would improve the