Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-07-01 Thread Junio C Hamano
Jens Lehmann writes: > Am 02.06.2013 20:50, schrieb Junio C Hamano: >> Jens Lehmann writes: >> >>> Am 30.05.2013 01:58, schrieb Junio C Hamano: * jl/submodule-mv (2013-04-23) 5 commits (merged to 'next' on 2013-04-23 at c04f574) + submodule.c: duplicate real_path's return valu

Re: Re: Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-06-05 Thread John Keeping
On Tue, Jun 04, 2013 at 06:57:34PM -0400, Phil Hord wrote: > On Tue, Jun 4, 2013 at 8:48 AM, John Keeping wrote: > > The problem is that sometimes you do want to adjust the path and > > sometimes you don't. Reading git-submodule(1), it says: > > > > This may be either an absolute URL, or (if

Re: Re: Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-06-04 Thread Phil Hord
On Tue, Jun 4, 2013 at 8:48 AM, John Keeping wrote: > On Tue, Jun 04, 2013 at 09:17:17PM +1000, Heiko Voigt wrote: >> On Tue, Jun 04, 2013 at 09:10:45AM +0100, John Keeping wrote: >> > On Tue, Jun 04, 2013 at 03:29:51PM +1000, Heiko Voigt wrote: >> > > On Mon, Jun 03, 2013 at 11:23:41PM +0100, Joh

Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-06-04 Thread John Keeping
On Tue, Jun 04, 2013 at 11:39:25PM +0200, Jens Lehmann wrote: > Am 04.06.2013 14:48, schrieb John Keeping: > > The problem is that sometimes you do want to adjust the path and > > sometimes you don't. Reading git-submodule(1), it says: > > > > This may be either an absolute URL, or (if it be

Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-06-04 Thread Jens Lehmann
Am 04.06.2013 14:48, schrieb John Keeping: > On Tue, Jun 04, 2013 at 09:17:17PM +1000, Heiko Voigt wrote: >> On Tue, Jun 04, 2013 at 09:10:45AM +0100, John Keeping wrote: >>> On Tue, Jun 04, 2013 at 03:29:51PM +1000, Heiko Voigt wrote: On Mon, Jun 03, 2013 at 11:23:41PM +0100, John Keeping wro

Re: Re: Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-06-04 Thread John Keeping
On Tue, Jun 04, 2013 at 09:17:17PM +1000, Heiko Voigt wrote: > On Tue, Jun 04, 2013 at 09:10:45AM +0100, John Keeping wrote: > > On Tue, Jun 04, 2013 at 03:29:51PM +1000, Heiko Voigt wrote: > > > On Mon, Jun 03, 2013 at 11:23:41PM +0100, John Keeping wrote: > > > > > Sorry, I should have been more

Re: Re: Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-06-04 Thread Heiko Voigt
On Tue, Jun 04, 2013 at 09:10:45AM +0100, John Keeping wrote: > On Tue, Jun 04, 2013 at 03:29:51PM +1000, Heiko Voigt wrote: > > On Mon, Jun 03, 2013 at 11:23:41PM +0100, John Keeping wrote: > > > > Sorry, I should have been more specific here. I saw that you did some > > > > changes to make "submo

Re: Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-06-04 Thread John Keeping
On Tue, Jun 04, 2013 at 03:29:51PM +1000, Heiko Voigt wrote: > On Mon, Jun 03, 2013 at 11:23:41PM +0100, John Keeping wrote: > > > Sorry, I should have been more specific here. I saw that you did some > > > changes to make "submodule add" do the right thing with relative paths, > > > but the follow

Re: Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-06-03 Thread Heiko Voigt
On Mon, Jun 03, 2013 at 11:23:41PM +0100, John Keeping wrote: > > Sorry, I should have been more specific here. I saw that you did some > > changes to make "submodule add" do the right thing with relative paths, > > but the following change to t7406 does not work like I believe it > > should but in

Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-06-03 Thread John Keeping
On Mon, Jun 03, 2013 at 11:47:23PM +0200, Jens Lehmann wrote: > Am 31.05.2013 21:40, schrieb John Keeping: > > The current version does make '$sm_path' relative in "submodule > > foreach", although it's hard to spot because we have to leave doing so > > until right before the "eval". > > Yes. If I

Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-06-03 Thread Jens Lehmann
Am 31.05.2013 21:40, schrieb John Keeping: > On Thu, May 30, 2013 at 09:23:40PM +0200, Jens Lehmann wrote: >> Am 30.05.2013 01:58, schrieb Junio C Hamano: >>> * jk/submodule-subdirectory-ok (2013-04-24) 3 commits >>> (merged to 'next' on 2013-04-24 at 6306b29) >>> + submodule: fix quoting in rel

Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-06-03 Thread Jens Lehmann
Am 02.06.2013 20:50, schrieb Junio C Hamano: > Jens Lehmann writes: > >> Am 30.05.2013 01:58, schrieb Junio C Hamano: >>> * jl/submodule-mv (2013-04-23) 5 commits >>> (merged to 'next' on 2013-04-23 at c04f574) >>> + submodule.c: duplicate real_path's return value >>> (merged to 'next' on 20

Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-06-03 Thread Junio C Hamano
John Keeping writes: > I started looking at this over the weekend but didn't get time to get > something ready to be submitted. I did find a couple of issues in > cmd_foreach that make me think this topic should be dropped when "next" > is rewound and held in pu waiting for a re-roll. Thanks fo

Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-06-03 Thread John Keeping
On Fri, May 31, 2013 at 08:40:51PM +0100, John Keeping wrote: > On Thu, May 30, 2013 at 09:23:40PM +0200, Jens Lehmann wrote: > > Am 30.05.2013 01:58, schrieb Junio C Hamano: > > > * jk/submodule-subdirectory-ok (2013-04-24) 3 commits > > > (merged to 'next' on 2013-04-24 at 6306b29) > > > + sub

Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-06-02 Thread Junio C Hamano
Thomas Rast writes: > This interacts with the tests from > >> * fc/at-head (2013-05-08) 13 commits > > to fail valgrind in t1508 like so: > > ==22927== Invalid read of size 1 > ==22927==at 0x4C2C71B: __GI_strnlen (mc_replace_strmem.c:377) > ==22927==by 0x567FF6B: vfprintf (in /lib64

Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-06-02 Thread Junio C Hamano
Jens Lehmann writes: > Am 30.05.2013 01:58, schrieb Junio C Hamano: >> * jl/submodule-mv (2013-04-23) 5 commits >> (merged to 'next' on 2013-04-23 at c04f574) >> + submodule.c: duplicate real_path's return value >> (merged to 'next' on 2013-04-19 at 45ae3c9) >> + rm: delete .gitmodules entr

Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-05-31 Thread John Keeping
On Thu, May 30, 2013 at 09:23:40PM +0200, Jens Lehmann wrote: > Am 30.05.2013 01:58, schrieb Junio C Hamano: > > * jk/submodule-subdirectory-ok (2013-04-24) 3 commits > > (merged to 'next' on 2013-04-24 at 6306b29) > > + submodule: fix quoting in relative_path() > > (merged to 'next' on 2013-0

Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-05-30 Thread Øystein Walle
Junio C Hamano pobox.com> writes: > * kb/status-ignored-optim-2 (2013-05-29) 1 commit > - dir.c: fix ignore processing within not-ignored directories > > Fix 1.8.3 regressions in the .gitignore path exclusion logic. Hi, I see that the Tested-by line in kb/status-ignored-optim-2 (3973cbd) doe

Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-05-30 Thread Jens Lehmann
Am 30.05.2013 01:58, schrieb Junio C Hamano: > * jk/submodule-subdirectory-ok (2013-04-24) 3 commits > (merged to 'next' on 2013-04-24 at 6306b29) > + submodule: fix quoting in relative_path() > (merged to 'next' on 2013-04-22 at f211e25) > + submodule: drop the top-level requirement > + rev

Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-05-30 Thread Jens Lehmann
Am 30.05.2013 01:58, schrieb Junio C Hamano: > * jl/submodule-mv (2013-04-23) 5 commits > (merged to 'next' on 2013-04-23 at c04f574) > + submodule.c: duplicate real_path's return value > (merged to 'next' on 2013-04-19 at 45ae3c9) > + rm: delete .gitmodules entry of submodules removed from t

Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-05-30 Thread Ramkumar Ramachandra
Thomas Rast wrote: > diff --git i/sha1_name.c w/sha1_name.c > index 5ea16ff..a07558d 100644 > --- i/sha1_name.c > +++ w/sha1_name.c > @@ -538,7 +538,6 @@ static int get_sha1_basic(const char *str, int len, > unsigned char *sha1) > "back to %s.", len, str, >

Re: What's cooking in git.git (May 2013, #09; Wed, 29)

2013-05-30 Thread Thomas Rast
Junio C Hamano writes: > * rr/die-on-missing-upstream (2013-05-22) 2 commits > - sha1_name: fix error message for @{}, @{} > - sha1_name: fix error message for @{u} > > When a reflog notation is used for implicit "current branch", we > did not say which branch and worse said "branch ''". > >