Rohit Ashiwal writes:
> Just to be clear of what caused the error:
> 1. Path not being file, or
> 2. File not being empty
> I am checking for both.
test -s makes sure is file; if it is not a file, then
it won't yield true.
So why do you need to say test_path_is_file yourself, if y
Mihir Mehta writes:
> Thanks, Junio. Instead of removing that part of the patch, I opted to
> expand it to make it a little clearer (in my opinion) than it was
> before. Let me know if this works.
I am mildly negative on that change. "Omitting both would give an
empty diff" would be understanda
miwilli...@google.com writes:
> From 7201fe08ede76e502211a781250c9a0b702a78b2 Mon Sep 17 00:00:00 2001
> From: Mike Williams
> Date: Mon, 11 Apr 2016 14:18:39 -0400
> Subject: [PATCH 1/1] wt-status: Remove '!!' from
> wt_status_collect_changed_cb
>
> The wt_status_collect_changed_cb function uses
3 matches
Mail list logo