Re: Suggestion: add author info to TODO list in git-rebase--interactive

2015-06-07 Thread Junio C Hamano
Mike Rappazzo rappa...@gmail.com writes: diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index dc3133f..e2d5ffc 100644 --- a/git-rebase--interactive.sh +++ b/git-rebase--interactive.sh @@ -977,7 +977,18 @@ else revisions=$onto...$orig_head shortrevisions=$shorthead

Suggestion: add author info to TODO list in git-rebase--interactive

2015-06-05 Thread Mike Rappazzo
I find that If I am doing a rebase with the intention to squash or re-order commits, it is helpful to know the commit author. However, the alteration that I have made to git-rebase--interactive may not be entirely correct. Here is the change: --- diff --git a/git-rebase--interactive.sh

Re: Suggestion: add author info to TODO list in git-rebase--interactive

2015-06-05 Thread Eric Sunshine
On Fri, Jun 5, 2015 at 3:35 PM, Junio C Hamano gits...@pobox.com wrote: Mike Rappazzo rappa...@gmail.com writes: I find that If I am doing a rebase with the intention to squash or re-order commits, it is helpful to know the commit author. There is not a fundamental reason why the remainder of

Re: Suggestion: add author info to TODO list in git-rebase--interactive

2015-06-05 Thread Junio C Hamano
Mike Rappazzo rappa...@gmail.com writes: I find that If I am doing a rebase with the intention to squash or re-order commits, it is helpful to know the commit author. There is not a fundamental reason why the remainder of the line after the object name in the rebase insn sheet should not be

Re: Suggestion: add author info to TODO list in git-rebase--interactive

2015-06-05 Thread Mike Rappazzo
I think the custom format makes sense. I took a first pass. A config option 'rebase.interactive.todo-format' can override the default 'oneline' format of the TODO list. Since the list is parsed using the left, right or boundary mark plus the sha1, then if the custom format does not start with