So I end up doing this manually when I notice, but I was wondering ig
maybe git could just have an option to "git am" and friends to
de-tabify the commit message.
It's particularly noticeable when people line things up using tabs
(for the kernel, it's often things like "cpu1 does X, cpu2 does Y"),
On Tue, Mar 15, 2016 at 5:16 PM, Linus Torvalds
wrote:
> Do people hate that idea? I may not get around to it for a while (it's
> the kernel merge window right now), but I can write the patch
> eventually - I just wanted to do an RFC first.
Could you point at some example to better understand the
On March 15, 2016 8:17 PM Linus Torvalds wrote:
> So I end up doing this manually when I notice, but I was wondering ig maybe
> git could just have an option to "git am" and friends to de-tabify the commit
> message.
>
> It's particularly noticeable when people line things up using tabs (for the
>
On Tue, Mar 15, 2016 at 5:23 PM, Stefan Beller wrote:
>
> Could you point at some example to better understand the problem?
So in the kernel repo, I just randomly looked for tabs that show this
problem, and take for example commit
ff9a9b4c4334b53b52ee9279f30bd5dd92ea9bdd.
You can see how the ori
Linus Torvalds writes:
> Do people hate that idea? I may not get around to it for a while (it's
> the kernel merge window right now), but I can write the patch
> eventually - I just wanted to do an RFC first.
Wouldn't it be nicer to do this kind of thing at the output side? A
stupid way would b
On Tue, Mar 15, 2016 at 5:45 PM, Junio C Hamano wrote:
>
> Wouldn't it be nicer to do this kind of thing at the output side? A
> stupid way would be to have an option to indent the log text with a
> tab instead of 4-spaces, but a more sensible way would be to keep
> the visual 4-space-indent and
On Tue, Mar 15, 2016 at 5:48 PM, Linus Torvalds
wrote:
> On Tue, Mar 15, 2016 at 5:45 PM, Junio C Hamano wrote:
>>
>> Wouldn't it be nicer to do this kind of thing at the output side? A
>> stupid way would be to have an option to indent the log text with a
>> tab instead of 4-spaces, but a more
On Tue, Mar 15, 2016 at 6:00 PM, Stefan Beller wrote:
>
> Instead of converting to whitespaces in Git, we could make use of the
> set_tabs capability for ttys and setup the terminal for having tabs align
> to 12,+8,+8,+8...
Or rather read in the existing tabs configuration and shift it by a const
On Tue, Mar 15, 2016 at 5:48 PM, Linus Torvalds
wrote:
> On Tue, Mar 15, 2016 at 5:45 PM, Junio C Hamano wrote:
>>
>> Wouldn't it be nicer to do this kind of thing at the output side? A
>> stupid way would be to have an option to indent the log text with a
>> tab instead of 4-spaces, but a more
Linus Torvalds writes:
> Here's a first try at it. It does tab expansion only for the cases
> that indent the commit message, so for things like "pretty=email" it
> makes no difference at all.
It also ignores that byte counts of non-HT bytes may not necessarily
match display columns. There is u
On Tue, Mar 15, 2016 at 9:46 PM, Junio C Hamano wrote:
>
> It also ignores that byte counts of non-HT bytes may not necessarily
> match display columns. There is utf8_width() function exported from
> utf8.c for that purpose.
Hmm. I did that to now make it horribly slower. Doing the
per-character
On Tue, Mar 15, 2016 at 09:57:16PM -0700, Linus Torvalds wrote:
> On Tue, Mar 15, 2016 at 9:46 PM, Junio C Hamano wrote:
> >
> > It also ignores that byte counts of non-HT bytes may not necessarily
> > match display columns. There is utf8_width() function exported from
> > utf8.c for that purpos
Linus Torvalds writes:
> On Wed, Mar 16, 2016 at 7:27 AM, Marc Branchaud wrote:
>>
>> Could this also help with diff output, where the leading + or - mars the
>> indentation in a similar way?
>
> I don't think that's a good idea at least by default, since then it
> will break things like running
On 16-03-15 09:02 PM, Stefan Beller wrote:
> On Tue, Mar 15, 2016 at 6:00 PM, Stefan Beller wrote:
>>
>> Instead of converting to whitespaces in Git, we could make use of the
>> set_tabs capability for ttys and setup the terminal for having tabs align
>> to 12,+8,+8,+8...
>
> Or rather read in th
On Wed, Mar 16, 2016 at 9:27 PM, Marc Branchaud wrote:
> On 16-03-15 09:02 PM, Stefan Beller wrote:
>> On Tue, Mar 15, 2016 at 6:00 PM, Stefan Beller wrote:
>>>
>>> Instead of converting to whitespaces in Git, we could make use of the
>>> set_tabs capability for ttys and setup the terminal for ha
On Wed, Mar 16, 2016 at 7:27 AM, Marc Branchaud wrote:
>
> Could this also help with diff output, where the leading + or - mars the
> indentation in a similar way?
I don't think that's a good idea at least by default, since then it
will break things like running diff in emacs capture mode.
So ev
Marc Branchaud writes:
> On 16-03-15 09:02 PM, Stefan Beller wrote:
>> On Tue, Mar 15, 2016 at 6:00 PM, Stefan Beller wrote:
>>>
>>> Instead of converting to whitespaces in Git, we could make use of the
>>> set_tabs capability for ttys and setup the terminal for having tabs align
>>> to 12,+8,+8
17 matches
Mail list logo