On Fri, Feb 19, 2016 at 02:33:10PM -0500, Jeff King wrote:
> On Fri, Feb 19, 2016 at 07:23:11PM +, John Keeping wrote:
>
> > I suspect that any grep that lacks "-a" also lacks binary file handling
> > that will break these tests. I found a Solaris grep that doesn't
> > support "-a" and it
On Fri, Feb 19, 2016 at 07:23:11PM +, John Keeping wrote:
> I suspect that any grep that lacks "-a" also lacks binary file handling
> that will break these tests. I found a Solaris grep that doesn't
> support "-a" and it treats these files as text.
>
> From that perspective, it would be
On Fri, Feb 19, 2016 at 09:38:17AM -0800, Junio C Hamano wrote:
> Jeff King writes:
>
> > Yeah, I'd worry that "-a" is not portable. OTOH, BSD grep seems to have
> > it, so between that and GNU, I think most systems are covered. We could
> > do:
> >
> > test_lazy_prereq GREP_A '
On Fri, Feb 19, 2016 at 09:38:17AM -0800, Junio C Hamano wrote:
> Jeff King writes:
>
> > Yeah, I'd worry that "-a" is not portable. OTOH, BSD grep seems to have
> > it, so between that and GNU, I think most systems are covered. We could
> > do:
> >
> > test_lazy_prereq GREP_A
Jeff King writes:
> Yeah, I'd worry that "-a" is not portable. OTOH, BSD grep seems to have
> it, so between that and GNU, I think most systems are covered. We could
> do:
>
> test_lazy_prereq GREP_A '
> echo foo | grep -a foo
> '
>
> and mark these tests with it. I'd
On Fri, Feb 19, 2016 at 6:59 AM, Jeff King wrote:
> On Sun, Feb 07, 2016 at 04:25:40PM +, John Keeping wrote:
>> The following patch fixes the tests for me, but I wonder if "-a" is
>> supported on all target platforms (it's not in POSIX, which specifies
>> that the "input files
On Sun, Feb 07, 2016 at 04:25:40PM +, John Keeping wrote:
> It seems that binary file detection has changed in GNU grep 2.23 as a
> result of commit 40ed879 (grep: fix bug with with invalid unibyte
> sequence).
I read this bug report a while ago when you posted it, but happily
ignored it
It seems that binary file detection has changed in GNU grep 2.23 as a
result of commit 40ed879 (grep: fix bug with with invalid unibyte
sequence).
This causes a couple of test failures in t8005 and t9200 (the t9200 case
is less obvious so I'm only including t8005 here):
-- >8 --
$
8 matches
Mail list logo