Use mongoose to test smart-http unconditionally?

2013-12-04 Thread Duy Nguyen
I was thinking of an alternative to apache for testing smart-http so that most of http tests could always run. Mongoose [1] looks like a good candidate to bundle with git. Just one pair of source files, mongoose.[ch], a mainloop wrapper and we have an http server. Just wondering, do we rely on any

Re: Use mongoose to test smart-http unconditionally?

2013-12-04 Thread Shawn Pearce
On Wed, Dec 4, 2013 at 2:53 AM, Duy Nguyen pclo...@gmail.com wrote: I was thinking of an alternative to apache for testing smart-http so that most of http tests could always run. Mongoose [1] looks like a good candidate to bundle with git. Just one pair of source files, mongoose.[ch], a

Re: Use mongoose to test smart-http unconditionally?

2013-12-04 Thread Jeff King
On Wed, Dec 04, 2013 at 10:13:11AM -0800, Shawn Pearce wrote: On Wed, Dec 4, 2013 at 2:53 AM, Duy Nguyen pclo...@gmail.com wrote: I was thinking of an alternative to apache for testing smart-http so that most of http tests could always run. Mongoose [1] looks like a good candidate to

Re: Use mongoose to test smart-http unconditionally?

2013-12-04 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: I was thinking of an alternative to apache for testing smart-http so that most of http tests could always run. Mongoose [1] looks like a good candidate to bundle with git. Just one pair of source files, mongoose.[ch], a mainloop wrapper and we have an

Re: Use mongoose to test smart-http unconditionally?

2013-12-04 Thread Jeff King
On Wed, Dec 04, 2013 at 12:09:09PM -0800, Junio C Hamano wrote: Duy Nguyen pclo...@gmail.com writes: I was thinking of an alternative to apache for testing smart-http so that most of http tests could always run. Mongoose [1] looks like a good candidate to bundle with git. Just one pair

Re: Use mongoose to test smart-http unconditionally?

2013-12-04 Thread Junio C Hamano
Jeff King p...@peff.net writes: The rollout would be: 1. add contrib/mongoose/* 2. add test-httpd which links against mongoose, built by default in the Makefile 3. convert lib-httpd/apache.conf into mongoose config as necessary 4. convert lib-httpd.sh to run test-httpd

Re: Use mongoose to test smart-http unconditionally?

2013-12-04 Thread Jonathan Nieder
Jeff King wrote: I don't know if it is worth all that much effort, though. I suppose it could get us more exposure to the httpd tests, but I do not know if it would be a good idea to turn them on by default anyway. They touch global machine resources (like ports) that can cause conflicts or

Re: Use mongoose to test smart-http unconditionally?

2013-12-04 Thread Duy Nguyen
On Thu, Dec 5, 2013 at 6:28 AM, Jonathan Nieder jrnie...@gmail.com wrote: Jeff King wrote: I don't know if it is worth all that much effort, though. I suppose it could get us more exposure to the httpd tests, but I do not know if it would be a good idea to turn them on by default anyway. They

Re: Use mongoose to test smart-http unconditionally?

2013-12-04 Thread Jeff King
On Wed, Dec 04, 2013 at 02:53:13PM -0800, Junio C Hamano wrote: If it involves making things not tested with apache, I'd actually be less supportive for the whole plan. I hadn't really considered that angle. Apache is a much more realistic real-world deployment. We give advice for it in

Re: Use mongoose to test smart-http unconditionally?

2013-12-04 Thread Jeff King
On Wed, Dec 04, 2013 at 03:28:00PM -0800, Jonathan Nieder wrote: For what it's worth, when I build git and run tests I tend to be in an environment with apache available, but I'm too lazy to configure git's tests to pick the right port and make sure it is reserved and so on. Perhaps there's