Re: [PATCH 3/4] add -u: only show pathless 'add -u' warning when changes exist outside cwd

2013-03-18 Thread Junio C Hamano
such a workflow: when the only changes present are in the current directory, 'git add -u' will add all changes, and whether that happens via an implicit . or implicit :/ parameter is an unimportant implementation detail. The warning about use of 'git add -u' with no pathspec is annoying

Re: [PATCH 3/4] add -u: only show pathless 'add -u' warning when changes exist outside cwd

2013-03-18 Thread Jonathan Nieder
add_files_to_cache() call underlying run_diff_files() without any pathspec, inspect the paths that are modified and/or deleted in the update_callback, add ones that are under the $prefix while noticing the ones outside as warning worthy events. Yes, that can work, for example like this (replacing

Re: [PATCH 3/4] add -u: only show pathless 'add -u' warning when changes exist outside cwd

2013-03-18 Thread Jonathan Nieder
. This warning prepares for * that change. */ - if (implicit_dot) + if (prefix implicit_dot) diff_files_with_callback(prefix, NULL, warn_if_outside_pathspec, pathspec); -- To unsubscribe from this list: send the line

Re: [PATCH 3/4] add -u: only show pathless 'add -u' warning when changes exist outside cwd

2013-03-18 Thread Duy Nguyen
, add ones that are under the $prefix while noticing the ones outside as warning worthy events. My concern is run full-tree diff can be expensive on large repos (one of the reasons the user may choose to work from within a subdirectory). We can exit as soon as we find a difference outside $prefix

Re: [PATCH 3/4] add -u: only show pathless 'add -u' warning when changes exist outside cwd

2013-03-18 Thread Jonathan Nieder
Duy Nguyen wrote: My concern is run full-tree diff can be expensive on large repos (one of the reasons the user may choose to work from within a subdirectory). We can exit as soon as we find a difference outside $prefix. But in case we find nothing, we need to diff the whole worktree. Yes.

[PATCH 1/2] add: update pathless 'add [-u|-A]' warning to reflect change of plan

2013-03-11 Thread Matthieu Moy
We originally thought the transition would need a period where git add [-u|-A] without pathspec would be forbidden, but the warning is big enough to scare people and teach them not to use it (or, if so, to understand the consequences). Signed-off-by: Matthieu Moy matthieu@imag.fr --- builtin

[PATCH 2/2] add: add a newline at the end of pathless 'add [-u|-A]' warning

2013-03-11 Thread Matthieu Moy
When the commands give an actual output (e.g. when ran with -v), the output is visually mixed with the warning. The newline makes the actual output more visible. Signed-off-by: Matthieu Moy matthieu@imag.fr --- builtin/add.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 2/2] add: add a newline at the end of pathless 'add [-u|-A]' warning

2013-03-11 Thread Junio C Hamano
Matthieu Moy matthieu@imag.fr writes: When the commands give an actual output (e.g. when ran with -v), the output is visually mixed with the warning. The newline makes the actual output more visible. Signed-off-by: Matthieu Moy matthieu@imag.fr --- It would have been easier

[PATCH v3 1/4] difftool: silence uninitialized variable warning

2013-02-20 Thread David Aguilar
Git::config() returns `undef` when given keys that do not exist. Check that the $guitool value is defined to prevent a noisy Use of uninitialized variable $guitool in length warning. Signed-off-by: David Aguilar dav...@gmail.com --- Unchanged since v1. git-difftool.perl | 2 +- 1 file changed

[PATCH v2 1/4] difftool: silence uninitialized variable warning

2013-02-19 Thread David Aguilar
Git::config() returns `undef` when given keys that do not exist. Check that the $guitool value is defined to prevent a noisy Use of uninitialized variable $guitool in length warning. Signed-off-by: David Aguilar dav...@gmail.com --- Unchanged from last time but included in the series

[PATCH 1/4] difftool: silence uninitialized variable warning

2013-02-15 Thread David Aguilar
Git::config() returns `undef` when given keys that do not exist. Check that the $guitool value is defined to prevent a noisy Use of uninitialized variable $guitool in length warning. Signed-off-by: David Aguilar dav...@gmail.com --- git-difftool.perl | 2 +- 1 file changed, 1 insertion(+), 1

Cumulative git read-tree -m rejected with overwriting warning

2013-02-13 Thread Marcin Owsiany
Hello, Consider the following use case: git init seq 0 9 f git add f git commit -m start git checkout -b b1 perl -pi -e 's,0,b1,' f git commit -a -m b1 git checkout -b b2 perl -pi -e 's,9,b2,' f git commit -a -m b2 git checkout master git merge b1 b1 As the

Re: Cumulative git read-tree -m rejected with overwriting warning

2013-02-13 Thread Junio C Hamano
Marcin Owsiany mar...@owsiany.pl writes: the index file saves and restores with all this information, so you can merge things incrementally, which I took to mean that I can read from multiple trees one by one before writing the tree. That incrementally refers to after a three-way merge

Re: [PATCH 2/3] combine-diff: suppress a clang warning

2013-02-07 Thread John Keeping
On Thu, Feb 07, 2013 at 01:12:59PM +0900, Miles Bader wrote: John Keeping j...@keeping.me.uk writes: I generally like to get rid of the pointless warnings so that the useful ones can't hide in the noise. Perhaps CFLAGS += -Wno-string-plus-int would be better for this particular warning

Re: [PATCH 2/3] combine-diff: suppress a clang warning

2013-02-06 Thread Miles Bader
John Keeping j...@keeping.me.uk writes: I generally like to get rid of the pointless warnings so that the useful ones can't hide in the noise. Perhaps CFLAGS += -Wno-string-plus-int would be better for this particular warning, but when there's only one bit of code that triggers it, tweaking

[PATCH 0/3] Make Git compile warning-free with Clang

2013-02-03 Thread John Keeping
/gmane.comp.version-control.git/213817 [2] http://article.gmane.org/gmane.comp.version-control.git/213849 Antoine Pelisse (1): fix clang -Wtautological-compare with unsigned enum John Keeping (2): combine-diff: suppress a clang warning builtin/apply: tighten (dis)similarity index parsing

[PATCH 2/3] combine-diff: suppress a clang warning

2013-02-03 Thread John Keeping
When compiling combine-diff.c, clang 3.2 says: combine-diff.c:1006:19: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int] prefix = COLONS + offset; ~~~^~~~ combine-diff.c:1006:19: note: use array

Re: [PATCH 0/3] Make Git compile warning-free with Clang

2013-02-03 Thread Antoine Pelisse
Thanks John, I couldn't find any time to send that sum-up series. On Sun, Feb 3, 2013 at 3:37 PM, John Keeping j...@keeping.me.uk wrote: The first two patches here were sent to the list before but seem to have got lost in the noise [1][2]. The final one is new but was prompted by discussion

Re: [PATCH 2/3] combine-diff: suppress a clang warning

2013-02-03 Thread Tay Ray Chuan
On Sun, Feb 3, 2013 at 10:37 PM, John Keeping j...@keeping.me.uk wrote: When compiling combine-diff.c, clang 3.2 says: combine-diff.c:1006:19: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int] prefix = COLONS + offset

Re: [PATCH 2/3] combine-diff: suppress a clang warning

2013-02-03 Thread John Keeping
On Mon, Feb 04, 2013 at 02:20:06AM +0800, Tay Ray Chuan wrote: On Sun, Feb 3, 2013 at 10:37 PM, John Keeping j...@keeping.me.uk wrote: When compiling combine-diff.c, clang 3.2 says: combine-diff.c:1006:19: warning: adding 'int' to a string does not append to the string

Re: [PATCH 2/3] combine-diff: suppress a clang warning

2013-02-03 Thread Junio C Hamano
John Keeping j...@keeping.me.uk writes: When compiling combine-diff.c, clang 3.2 says: combine-diff.c:1006:19: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int] prefix = COLONS + offset

Re: [PATCH 2/3] combine-diff: suppress a clang warning

2013-02-03 Thread John Keeping
On Sun, Feb 03, 2013 at 11:58:15AM -0800, Junio C Hamano wrote: John Keeping j...@keeping.me.uk writes: When compiling combine-diff.c, clang 3.2 says: combine-diff.c:1006:19: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int

Re: [PATCH 2/3] combine-diff: suppress a clang warning

2013-02-03 Thread Junio C Hamano
John Keeping j...@keeping.me.uk writes: A quick search turned up the original thread where this feature was added to Clang [1]. It seems that it does find genuine bugs where people try to log values by doing: log(failed to handle error: + errno); To be perfectly honest, anybody who

Re: [PATCH 2/3] combine-diff: suppress a clang warning

2013-02-03 Thread John Keeping
that the useful ones can't hide in the noise. Perhaps CFLAGS += -Wno-string-plus-int would be better for this particular warning, but when there's only one bit of code that triggers it, tweaking that seemed simpler. combine-diff.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions

Re: [PATCH 2/3] combine-diff: suppress a clang warning

2013-02-03 Thread Junio C Hamano
for this particular warning, but when there's only one bit of code that triggers it, tweaking that seemed simpler. Thanks for a sanity check. Ideally it should also have test cases to show git diff --cc --raw blob1 blob2...blob$n for n=4 and n=40 (or any two values clearly below and above the old hardcoded

Re: [PATCH] The images from picon and gravatar are always used over http://, and browsers give mixed contents warning when gitweb is served over https://.

2013-01-31 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes: Junio C Hamano wrote: Jonathan Nieder jrnie...@gmail.com writes: Odd. https://www.gravatar.com/; also seems to work. I've put in a technical support query to find out what the Gravatar admins prefer. Thanks; will hold onto Andrej's patch until

Re: [PATCH] The images from picon and gravatar are always used over http://, and browsers give mixed contents warning when gitweb is served over https://.

2013-01-30 Thread Jonathan Nieder
Junio C Hamano wrote: Jonathan Nieder jrnie...@gmail.com writes: Odd. https://www.gravatar.com/; also seems to work. I've put in a technical support query to find out what the Gravatar admins prefer. Thanks; will hold onto Andrej's patch until we hear what the story is. Good news: a kind

Re: [PATCH] The images from picon and gravatar are always used over http://, and browsers give mixed contents warning when gitweb is served over https://.

2013-01-29 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes: Odd. https://www.gravatar.com/; also seems to work. I've put in a technical support query to find out what the Gravatar admins prefer. Thanks; will hold onto Andrej's patch until we hear what the story is. Of course we could do something like this

[PATCH] The images from picon and gravatar are always used over http://, and browsers give mixed contents warning when gitweb is served over https://.

2013-01-28 Thread Andrej E Baranov
Just drop the scheme: part from the URL, so that these external sites are accessed over https:// in such a case. Signed-off-by: Andrej E Baranov ad...@andrej-andb.ru --- gitweb/gitweb.perl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gitweb/gitweb.perl

Re: [PATCH] The images from picon and gravatar are always used over http://, and browsers give mixed contents warning when gitweb is served over https://.

2013-01-28 Thread Junio C Hamano
Thanks; will queue. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] The images from picon and gravatar are always used over http://, and browsers give mixed contents warning when gitweb is served over https://.

2013-01-28 Thread Bryan Turner
This won't work correctly as-is. The secure URL for Gravatar is https://secure.gravatar.com[1], not https://www.gravatar.com;. [1] See the Secure Requests section on: https://en.gravatar.com/site/implement/images/ On 29 January 2013 14:03, Junio C Hamano gits...@pobox.com wrote: Thanks; will

Re: [PATCH] The images from picon and gravatar are always used over http://, and browsers give mixed contents warning when gitweb is served over https://.

2013-01-28 Thread Jonathan Nieder
Hi Bryan, Bryan Turner wrote: This won't work correctly as-is. The secure URL for Gravatar is https://secure.gravatar.com[1], not https://www.gravatar.com;. Odd. https://www.gravatar.com/; also seems to work. I've put in a technical support query to find out what the Gravatar admins prefer.

Re: [PATCH] The images from picon and gravatar are always used over http://, and browsers give mixed contents warning when gitweb is served over https://.

2013-01-28 Thread Bryan Turner
Interesting. I wonder if they've changed it recently. I only pointed it out because a software product I'm working on had a bug because it was building the URLs with https://www...; and the resulting images were showing as X's instead of avatars. We had to change the implementation to use

[PATCH] combine-diff: suppress a clang warning

2013-01-17 Thread John Keeping
When compiling combine-diff.c, clang 3.2 says: combine-diff.c:1006:19: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int] prefix = COLONS + offset; ~~~^~~~ combine-diff.c:1006:19: note: use array

[PATCH] builtin/reset.c: Fix a sparse warning

2013-01-14 Thread Ramsay Jones
In particular, sparse issues an symbol not declared. Should it be static? warning for the 'parse_args' function. Since this function does not require greater than file visibility, we suppress this warning by simply adding the static modifier to it's decalaration. Signed-off-by: Ramsay Jones ram

Re: [PATCH] builtin/reset.c: Fix a sparse warning

2013-01-14 Thread Martin von Zweigbergk
On Mon, Jan 14, 2013 at 11:28 AM, Ramsay Jones ram...@ramsay1.demon.co.uk wrote: In particular, sparse issues an symbol not declared. Should it be static? warning for the 'parse_args' function. Since this function does not require greater than file visibility, we suppress this warning

Re: Fwd: git-gui / Warning: No newline at end of file”

2013-01-09 Thread Pat Thoyts
is emitted by git at we don't appear to handle it well in the lib/diff.tcl apply_range_or_line function. -- Forwarded message -- From: Tobias Preuss tobias.pre...@googlemail.com Date: Tue, Nov 13, 2012 at 9:26 PM Subject: git-gui / Warning: No newline at end of file” To: git git

Re: [PATCH] add warning for depth=0 in git clone.

2013-01-08 Thread Stefan Beller
Hi, I am struggling a little with the development process, is a sign-off strictly required for git as it is for kernel development? If so here would be my sign-off: Signed-off-by: Stefan Beller stefanbel...@googlemail.com This adds a warning and the previous patch adds the documentation

Re: [PATCH] add warning for depth=0 in git clone.

2013-01-08 Thread Jonathan Nieder
Stefan Beller wrote: I am struggling a little with the development process, is a sign-off strictly required for git as it is for kernel development? Yes. Documentation/SubmittingPatches has more hints. Signed-off-by: Stefan Beller stefanbel...@googlemail.com This adds a warning

Re: [PATCH] add warning for depth=0 in git clone.

2013-01-08 Thread Duy Nguyen
On Tue, Jan 8, 2013 at 3:07 PM, Stefan Beller stefanbel...@googlemail.com wrote: --- builtin/clone.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/builtin/clone.c b/builtin/clone.c index ec2f75b..5e91c1e 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -818,6 +818,9 @@ int

[PATCH] mailmap.c: Fix a sparse warning

2012-12-15 Thread Ramsay Jones
In particular, sparse issues an Using plain integer as NULL pointer warning (line 214), since an integer zero is passed as the second actual argument in a strbuf_detach() call. The expected type for this parameter is 'size_t *'. In order to suppress the warning, we simply pass a NULL pointer

[PATCH] nedmalloc: Fix a compile warning (exposed as error) with GCC 4.7.2

2012-12-11 Thread Sebastian Schuberth
On MinGW, GCC 4.7.2 complains about operation on 'p-m[end]' may be undefined Fix this by replacing the faulty lines with those of 69825ca from https://github.com/ned14/nedmalloc/blob/master/nedmalloc.c Signed-off-by: Sebastian Schuberth sschube...@gmail.com ---

[PATCH] completion: fix warning for zsh

2012-11-29 Thread Felipe Contreras
@@ __gitk_main () if [[ -n ${ZSH_VERSION-} ]]; then echo WARNING: this script is deprecated, please see git-completion.zsh 12 + autoload -U +X compinit compinit + __gitcomp () { emulate -L zsh -- 1.8.0.1 -- To unsubscribe from this list: send

Re: [PATCH] completion: fix warning for zsh

2012-11-29 Thread Junio C Hamano
Will apply directly on 'master'; thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] remote-curl.c: Fix a compiler warning

2012-11-21 Thread Ramsay Jones
In particular, gcc issues an 'gzip_size' might be used uninitialized warning (-Wuninitialized). However, this warning is a false positive, since the 'gzip_size' variable would not, in fact, be used uninitialized. In order to suppress the warning, we simply initialise the variable to zero in it's

Re: [PATCH] remote-curl.c: Fix a compiler warning

2012-11-21 Thread Jeff King
On Wed, Nov 21, 2012 at 07:08:51PM +, Ramsay Jones wrote: In particular, gcc issues an 'gzip_size' might be used uninitialized warning (-Wuninitialized). However, this warning is a false positive, since the 'gzip_size' variable would not, in fact, be used uninitialized. In order

[PATCH] remote-curl.c: Fix a gcc warning

2012-11-10 Thread Ramsay Jones
In particular, gcc complains as follows: CC remote-curl.o remote-curl.c: In function `rpc_service': remote-curl.c:403: warning: 'gzip_size' might be used uninitialized \ in this function The 'gzip_size' variable would not, in fact, be used uninitialized. However

[PATCH] pretty.c: Fix a compiler warning

2012-10-04 Thread Ramsay Jones
In particular, gcc complains thus: CC pretty.o pretty.c: In function 'format_commit_item': pretty.c:1282: warning: 'offset' might be used uninitialized in \ this function In order to suppress the warning we simply initialize the 'offset' variable in it's declarartion

[PATCH] grep.c: Fix a sparse warning

2012-09-18 Thread Ramsay Jones
In particular, sparse complains that ... 'dump_grep_expression' was not declared. Should it be static?. In order to suppress the warning, since this function does not need more than file scope, we simply include the static modifier in it's declaration. Signed-off-by: Ramsay Jones ram...@ramsay1

Re: [PATCH] grep.c: Fix a sparse warning

2012-09-18 Thread Junio C Hamano
Ramsay Jones ram...@ramsay1.demon.co.uk writes: In particular, sparse complains that ... 'dump_grep_expression' was not declared. Should it be static?. In order to suppress the warning, since this function does not need more than file scope, we simply include the static modifier in it's

[PATCH] test-generation.c: Fix a compiler warning

2012-09-15 Thread Ramsay Jones
gcc complains as follows: CC test-generation.o test-generation.c: In function `main': test-generation.c:105: warning: control reaches end of \ non-void function In order to suppress the warning, we simply add a suitable return statement to main(). Signed-off-by: Ramsay

{bug} warning: unable to access 'RelNotes/.gitattributes'

2012-09-13 Thread Junio C Hamano
git repack started giving the above warning, and I am guessing that the recent 11e50b2 (attr: warn on inaccessible attribute files, 2012-08-21) exposed a bug where we ask stat(2) not lstat(2) by mistake before deciding to append .gitattributes to see if that directory has a per-directory

Re: {bug} warning: unable to access 'RelNotes/.gitattributes'

2012-09-13 Thread Jeff King
On Wed, Sep 12, 2012 at 11:32:22PM -0700, Junio C Hamano wrote: git repack started giving the above warning, and I am guessing that the recent 11e50b2 (attr: warn on inaccessible attribute files, 2012-08-21) exposed a bug where we ask stat(2) not lstat(2) by mistake before deciding to append

Re: {bug} warning: unable to access 'RelNotes/.gitattributes'

2012-09-13 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Wed, Sep 12, 2012 at 11:32:22PM -0700, Junio C Hamano wrote: git repack started giving the above warning, and I am guessing that the recent 11e50b2 (attr: warn on inaccessible attribute files, 2012-08-21) exposed a bug where we ask stat(2) not lstat(2

Re: {bug} warning: unable to access 'RelNotes/.gitattributes'

2012-09-13 Thread Jeff King
On Thu, Sep 13, 2012 at 12:40:39PM -0700, Junio C Hamano wrote: Interesting. I don't get any such warning on repack. And RelNotes points to a file, so I'm not sure why stat() would make us think it was a dir. Interesting. The command in question is git-pack-objects --keep-true-parents

[PATCH 2/2] i18n: mark prefix warning: for translation

2012-09-07 Thread Ralf Thielow
params) static void warn_builtin(const char *warn, va_list params) { - vreportf(warning: , warn, params); + print_with_prefix(_(warning:), warn, params); } /* If we are in a dlopen()ed .so write to a global variable would segfault -- 1.7.12.176.g3fc0e4c.dirty -- To unsubscribe from

Re: warning: There are too many unreachable loose objects; run 'git prune' to remove them.

2012-09-03 Thread Antony Male
On 29/08/2012 22:16, Dun Peal wrote: Hi, I am getting this error every time I pull. All the following have been executed, but failed to remove this warning: git prune git prune --expire now git gc git gc --aggressive What should I do? Was the error prefixed by 'remote:' (i.e

warning: There are too many unreachable loose objects; run 'git prune' to remove them.

2012-08-29 Thread Dun Peal
Hi, I am getting this error every time I pull. All the following have been executed, but failed to remove this warning: git prune git prune --expire now git gc git gc --aggressive What should I do? Thanks, D. -- To unsubscribe from this list: send the line unsubscribe git in the body

Re: [PATCH] difftool: silence warning

2012-08-21 Thread David Aguilar
On Mon, Aug 20, 2012 at 11:59 PM, Ross Lagerwall rosslagerw...@gmail.com wrote: Silence a warning given when running git difftool --dir-diff and there are no changes. This is because command_oneline returns undef when the command has no output, not ''. Signed-off-by: Ross Lagerwall

Re: [PATCH] difftool: silence warning

2012-08-21 Thread Ross Lagerwall
On 08/21/2012 11:04 AM, David Aguilar wrote: This patch is obviously correct, but it won't apply in git's next branch. Can you please prepare a patch based on the version in next? Sure. A small question on Perl style for the list... is it better say this? exit(0) unless $diffrtn;

[PATCH] difftool: silence warning

2012-08-21 Thread Ross Lagerwall
Silence a warning given when running git difftool --dir-diff and there are no changes. This is because command_oneline returns undef when the command has no output, not ''. Signed-off-by: Ross Lagerwall rosslagerw...@gmail.com --- git-difftool.perl | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] fast_export.c: Fix a compiler warning

2012-08-21 Thread Ramsay Jones
Florian Achleitner wrote: On Sunday 19 August 2012 16:29:02 Ramsay Jones wrote: Ok, I'll add it to the next version. This warning only occurs when building for 32bit, thus I never saw it. There would be a format flag for printf that sprecifies the platform's size_t integer type: z

Re: [PATCH] fast_export.c: Fix a compiler warning

2012-08-20 Thread Florian Achleitner
On Sunday 19 August 2012 16:29:02 Ramsay Jones wrote: In particular, gcc complains thus: CC vcs-svn/fast_export.o vcs-svn/fast_export.c: In function 'fast_export_begin_note': vcs-svn/fast_export.c:77: warning: long long unsigned int format, \ different type arg (arg

Re: [PATCH] fast_export.c: Fix a compiler warning

2012-08-20 Thread Junio C Hamano
d319a37c (Create a note for every imported commit containing svn metadata, 17-08-2012) instead. Note that, because of the context lines in the patch, it won't apply as-is.] Ok, I'll add it to the next version. This warning only occurs when building for 32bit, thus I never saw it. There would

Re: [msysGit] Re: Re: File path not escaped in warning message

2012-08-06 Thread karsten . blees
(usually UTF-8) 2. file content: printed verbatim (no re-coding); gui tools such as gitk may decode this based on gui.encoding or .gitattributes settings 3. everything else (file names, diff headers, error / warning messages): always UTF-8 (at least in Git for Windows) Gui tools such as gitk decode

Re: File path not escaped in warning message

2012-08-05 Thread Janusz Białobrzewski
Here is output from linux: [janusz@mikrus JavaCommon]$ git config --add core.quotepath false [janusz@mikrus JavaCommon]$ git diff --unified=3 -- 1ą.txt warning: LF will be replaced by CRLF in 1B1.txt. The file will have its original line endings in your working directory. diff --git a/1B1.txt b

File path not escaped in warning message

2012-08-04 Thread Janusz Białobrzewski
Hi, I have enabled core.quotepath, but file path in warning isn't escaped: File name is 1ą.txt its content is encoded in windows-1250 Output of git diff after reencoding to windows1250 is: warning: LF will be replaced by CRLF in 1Ä….txt. The file will have its original line endings in your

Re: File path not escaped in warning message

2012-08-04 Thread Junio C Hamano
Janusz Białobrzewski jbial...@o2.pl writes: I have enabled core.quotepath, but file path in warning isn't escaped: File name is 1ą.txt its content is encoded in windows-1250 Output of git diff after reencoding to windows1250 is: warning: LF will be replaced by CRLF in 1Ä….txt. The file

[PATCH 1/3] Quiet warning if Makefile.PL is run with -w and no --localedir

2012-07-24 Thread Michael G. Schwern
From: Michael G. Schwern schw...@pobox.com Usually it isn't, but its nice if it can be run with warnings on. Signed-off-by: Michael G Schwern schw...@pobox.com --- perl/Makefile.PL | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/perl/Makefile.PL b/perl/Makefile.PL index

[PATCH 7/9] vcs-svn: suppress a signed/unsigned comparison warning

2012-07-06 Thread Jonathan Nieder
From: David Barr davidb...@google.com Date: Fri, 1 Jun 2012 00:41:29 +1000 The preceding code checks that view-max_off is nonnegative and (off + width) fits in an off_t, so this code is already safe. Signed-off-by: David Barr davidb...@google.com Signed-off-by: Jonathan Nieder jrnie...@gmail.com

[PATCH 8/9] vcs-svn: suppress a signed/unsigned comparison warning

2012-07-06 Thread Jonathan Nieder
...@google.com Signed-off-by: Jonathan Nieder jrnie...@gmail.com --- v2 suppressed the warning by casting len to an off_t, producing an unintentional change (breakage) in functionality on 64-bit systems when len is large. This version is longer but more conservative. vcs-svn/svndiff.c |5 +++-- 1

x86: don't print a warning when MTRR are blank and running in KVM

2008-02-26 Thread Linux Kernel Mailing List
Feb 21 15:50:14 2008 +0100 Committer: Ingo Molnar [EMAIL PROTECTED] CommitDate: Tue Feb 26 12:55:57 2008 +0100 x86: don't print a warning when MTRR are blank and running in KVM Inside a KVM virtual machine the MTRRs are usually blank. This confuses Linux and causes a warning

[SCSI] qla2xxx: fix compile warning for printk format

2008-02-23 Thread Linux Kernel Mailing List
: Sat Feb 16 15:24:41 2008 +0900 Committer: James Bottomley [EMAIL PROTECTED] CommitDate: Mon Feb 18 08:57:17 2008 -0600 [SCSI] qla2xxx: fix compile warning for printk format scsi/qla2xxx/qla_dfs.c: In function 'qla2x00_dfs_fce_show': scsi/qla2xxx/qla_dfs.c:26: warning: format '%llx

mvsas: fix build warning, clean prototypes

2008-02-23 Thread Linux Kernel Mailing List
Feb 23 16:53:44 2008 -0500 Committer: Linus Torvalds [EMAIL PROTECTED] CommitDate: Sat Feb 23 17:52:36 2008 -0800 mvsas: fix build warning, clean prototypes - Fix build 'make randconfig' build warning spotted by Toralf Foerster: drivers/scsi/mvsas.c: In function 'mvs_hexdump

[SPARC64]: Fix sparse warning wrt. fault_in_user_windows.

2008-02-23 Thread Linux Kernel Mailing List
: Tue Feb 19 21:18:51 2008 -0800 Committer: David S. Miller [EMAIL PROTECTED] CommitDate: Tue Feb 19 21:18:51 2008 -0800 [SPARC64]: Fix sparse warning wrt. fault_in_user_windows. arch/sparc64/kernel/process.c:467:6: warning: symbol 'fault_in_user_windows' was not declared. Should

[SPARC64]: More sparse warning fixes in process.c

2008-02-23 Thread Linux Kernel Mailing List
: Tue Feb 19 21:25:50 2008 -0800 Committer: David S. Miller [EMAIL PROTECTED] CommitDate: Tue Feb 19 21:25:50 2008 -0800 [SPARC64]: More sparse warning fixes in process.c arch/sparc64/kernel/process.c:504:17: warning: symbol 'sparc_do_fork' was not declared. Should it be static

libata-core: fix kernel-doc warning

2008-02-23 Thread Linux Kernel Mailing List
Feb 22 12:21:37 2008 -0800 Committer: Jeff Garzik [EMAIL PROTECTED] CommitDate: Sun Feb 24 00:28:48 2008 -0500 libata-core: fix kernel-doc warning Fix libata-core kernel-doc warning: Warning(linux-2.6.25-rc2-git6//drivers/ata/libata-core.c:168): No description found

[ALSA] caiaq - fix section mismatch warning

2008-02-22 Thread Linux Kernel Mailing List
Feb 22 18:46:47 2008 +0100 Committer: Linus Torvalds [EMAIL PROTECTED] CommitDate: Fri Feb 22 14:20:09 2008 -0800 [ALSA] caiaq - fix section mismatch warning Fix following warning: WARNING: vmlinux.o(.text+0x11ec01a): Section mismatch in reference from the function setup_card

kernel-doc: fix pci-acpi warning

2008-02-21 Thread Linux Kernel Mailing List
Feb 3 15:06:25 2008 -0800 Committer: Len Brown [EMAIL PROTECTED] CommitDate: Fri Feb 15 18:21:20 2008 -0500 kernel-doc: fix pci-acpi warning Fix PCI kernel-doc warning: Warning(linux-2.6.24-git12//drivers/pci/pci-acpi.c:166): No description found for parameter 'hid

hwmon: (coretemp) fix section mismatch warning

2008-02-21 Thread Linux Kernel Mailing List
Feb 17 13:22:51 2008 +0100 Committer: Mark M. Hoffman [EMAIL PROTECTED] CommitDate: Sun Feb 17 11:26:55 2008 -0500 hwmon: (coretemp) fix section mismatch warning Fix following warning: WARNING: vmlinux.o(.text+0xebfd04): Section mismatch in reference from the function

[POWERPC] Fix warning in pseries/power.c

2008-02-21 Thread Linux Kernel Mailing List
: Wed Feb 20 11:27:04 2008 +1100 Committer: Paul Mackerras [EMAIL PROTECTED] CommitDate: Wed Feb 20 13:33:37 2008 +1100 [POWERPC] Fix warning in pseries/power.c Introduced by commit 79393fc46ede43451a500a132e5de9856f5a4c83 (kobject: convert pseries/power.c to kobj_attr interface

[ARM] 4829/1: add .get method to pxa-cpufreq to silence a warning

2008-02-21 Thread Linux Kernel Mailing List
: Mon Feb 11 16:53:15 2008 +0100 Committer: Russell King [EMAIL PROTECTED] CommitDate: Sun Feb 17 10:42:10 2008 + [ARM] 4829/1: add .get method to pxa-cpufreq to silence a warning The .get method is needed for suspend/resume. Otherwise you get this in dmesg: cpufreq

PCI: kernel-doc: fix pci-acpi warning

2008-02-21 Thread Linux Kernel Mailing List
Feb 3 15:06:25 2008 -0800 Committer: Greg Kroah-Hartman [EMAIL PROTECTED] CommitDate: Thu Feb 21 15:34:37 2008 -0800 PCI: kernel-doc: fix pci-acpi warning Fix PCI kernel-doc warning: Warning(linux-2.6.24-git12//drivers/pci/pci-acpi.c:166): No description found for parameter 'hid

[POWERPC] pasemi: Remove warning in mpic_pasemi_msi.c

2008-02-21 Thread Linux Kernel Mailing List
: Thu Feb 21 13:34:43 2008 +1100 Committer: Paul Mackerras [EMAIL PROTECTED] CommitDate: Thu Feb 21 21:08:35 2008 +1100 [POWERPC] pasemi: Remove warning in mpic_pasemi_msi.c Remove warning: arch/powerpc/sysdev/mpic_pasemi_msi.c: In function 'pasemi_msi_setup_msi_irqs': arch

ata: fix sparse warning in libata.h

2008-02-20 Thread Linux Kernel Mailing List
: Fri Feb 15 13:41:32 2008 -0800 Committer: Jeff Garzik [EMAIL PROTECTED] CommitDate: Wed Feb 20 12:12:47 2008 -0500 ata: fix sparse warning in libata.h Avoids lots of these, also is more readable. include/linux/libata.h:1210:13: warning: potentially expensive pointer subtraction

libata: fix kernel-doc parameter warning

2008-02-20 Thread Linux Kernel Mailing List
Feb 19 13:43:21 2008 -0800 Committer: Jeff Garzik [EMAIL PROTECTED] CommitDate: Wed Feb 20 12:20:49 2008 -0500 libata: fix kernel-doc parameter warning Fix libata kernel-doc parameter: Warning(linux-2.6.25-rc2-git3//drivers/ata/libata-scsi.c:845): No description found

[BLUETOOTH] hci_sysfs.c: Kill build warning.

2008-02-19 Thread Linux Kernel Mailing List
: Mon Feb 18 00:20:50 2008 -0800 Committer: David S. Miller [EMAIL PROTECTED] CommitDate: Mon Feb 18 00:20:50 2008 -0800 [BLUETOOTH] hci_sysfs.c: Kill build warning. net/bluetooth/hci_sysfs.c: In function ‘del_conn’: net/bluetooth/hci_sysfs.c:339: warning: suggest parentheses around

x86: fix section mismatch warning in setup_64.c:nearby_node

2008-02-19 Thread Linux Kernel Mailing List
Feb 17 13:22:46 2008 +0100 Committer: Ingo Molnar [EMAIL PROTECTED] CommitDate: Tue Feb 19 16:18:29 2008 +0100 x86: fix section mismatch warning in setup_64.c:nearby_node nearby_node() were only used by __cpuinit amd_detect_cmp() So annotating nearby_node() __cpuinit

x86: fix compile warning building without CONFIG_SYSCTL

2008-02-19 Thread Linux Kernel Mailing List
3 15:40:30 2008 +0800 Committer: Ingo Molnar [EMAIL PROTECTED] CommitDate: Tue Feb 19 16:18:29 2008 +0100 x86: fix compile warning building without CONFIG_SYSCTL arch/x86/kernel/nmi_64.c:50: warning: 'unknown_nmi_panic_callback' declared 'static' but never defined

x86: fix section mismatch warning in topology.c:arch_register_cpu

2008-02-19 Thread Linux Kernel Mailing List
Feb 17 13:22:49 2008 +0100 Committer: Ingo Molnar [EMAIL PROTECTED] CommitDate: Tue Feb 19 16:18:30 2008 +0100 x86: fix section mismatch warning in topology.c:arch_register_cpu arch_register_cpu() is only defined for HOTPLUG_CPU code so simple fix is to ignore references

V4L/DVB (7183): radio-si470x: fix build warning

2008-02-18 Thread Linux Kernel Mailing List
: Sun Feb 10 20:13:25 2008 -0300 Committer: Mauro Carvalho Chehab [EMAIL PROTECTED] CommitDate: Mon Feb 18 11:15:17 2008 -0300 V4L/DVB (7183): radio-si470x: fix build warning fix the following build warning: radio-si470x.c: In function 'si470x_get_rds_registers': radio

V4L/DVB (7110): Trivial printf warning fix (radio-si470)

2008-02-18 Thread Linux Kernel Mailing List
: Mon Jan 28 22:49:14 2008 -0300 Committer: Mauro Carvalho Chehab [EMAIL PROTECTED] CommitDate: Mon Feb 18 11:15:09 2008 -0300 V4L/DVB (7110): Trivial printf warning fix (radio-si470) Thanks to Darren Salt [EMAIL PROTECTED] for pointing this issue. Signed-off-by: Tobias

drivers/net/sis190: fix section mismatch warning in sis190_get_mac_addr

2008-02-15 Thread Linux Kernel Mailing List
Feb 10 17:56:25 2008 -0300 Committer: Jeff Garzik [EMAIL PROTECTED] CommitDate: Mon Feb 11 11:15:35 2008 -0500 drivers/net/sis190: fix section mismatch warning in sis190_get_mac_addr Fix following warnings: WARNING: drivers/net/sis190.o(.text+0x103): Section mismatch in reference

ata: fix sparse warning in libata-core.c

2008-02-15 Thread Linux Kernel Mailing List
: Thu Feb 14 10:45:23 2008 -0800 Committer: Jeff Garzik [EMAIL PROTECTED] CommitDate: Fri Feb 15 13:50:56 2008 -0500 ata: fix sparse warning in libata-core.c rc is used to test the return value and possibly return an error. No need to redeclare inside the loop. drivers/ata

ata: fix sparse warning in ata_piix.c

2008-02-15 Thread Linux Kernel Mailing List
: Wed Feb 13 21:14:05 2008 -0800 Committer: Jeff Garzik [EMAIL PROTECTED] CommitDate: Fri Feb 15 13:50:58 2008 -0500 ata: fix sparse warning in ata_piix.c drivers/ata/ata_piix.c:1655:8: warning: symbol 'rc' shadows an earlier one drivers/ata/ata_piix.c:1616:6: originally declared

ata: fix sparse warning in sata_promise.c

2008-02-15 Thread Linux Kernel Mailing List
: Wed Feb 13 21:14:08 2008 -0800 Committer: Jeff Garzik [EMAIL PROTECTED] CommitDate: Fri Feb 15 13:50:59 2008 -0500 ata: fix sparse warning in sata_promise.c drivers/ata/sata_promise.c:546:15: warning: symbol 'len' shadows an earlier one drivers/ata/sata_promise.c:538:6

ata: fix sparse warning in sata_via.c

2008-02-15 Thread Linux Kernel Mailing List
: Wed Feb 13 21:14:11 2008 -0800 Committer: Jeff Garzik [EMAIL PROTECTED] CommitDate: Fri Feb 15 13:51:01 2008 -0500 ata: fix sparse warning in sata_via.c drivers/ata/sata_via.c:336:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison [EMAIL PROTECTED

ata: fix sparse warning in pata_acpi.c

2008-02-15 Thread Linux Kernel Mailing List
: Wed Feb 13 21:14:31 2008 -0800 Committer: Jeff Garzik [EMAIL PROTECTED] CommitDate: Fri Feb 15 13:51:33 2008 -0500 ata: fix sparse warning in pata_acpi.c drivers/ata/pata_acpi.c:80:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison [EMAIL PROTECTED

FLAT binaries: drop BINFMT_FLAT bad header magic warning

2008-02-14 Thread Linux Kernel Mailing List
: Thu Feb 14 19:31:29 2008 -0800 Committer: Linus Torvalds [EMAIL PROTECTED] CommitDate: Thu Feb 14 20:58:05 2008 -0800 FLAT binaries: drop BINFMT_FLAT bad header magic warning The warning issued by fs/binfmt_flat.c when the format handler is given a non-FLAT and non-script

[POWERPC] Fix DEBUG_PREEMPT warning when warning

2008-02-14 Thread Linux Kernel Mailing List
Feb 9 05:25:13 2008 +1100 Committer: Paul Mackerras [EMAIL PROTECTED] CommitDate: Thu Feb 14 22:11:00 2008 +1100 [POWERPC] Fix DEBUG_PREEMPT warning when warning The powerpc show_regs prints CPU using smp_processor_id: change that to raw_smp_processor_id, so that when it's

<    2   3   4   5   6   7   8   9   10   11   >