Re: Why does git log -Gregex works with regexp-ignore-case but not with other regexp-related options?

2015-04-22 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 21.04.2015 18:59: Michael J Gruber g...@drmicha.warpmail.net writes: We have engine-switching options and engine-modification options. The latter are certainly good in the expression itself. Maybe even the former, though I don't know how to switch away from

Re: Why does git log -Gregex works with regexp-ignore-case but not with other regexp-related options?

2015-04-21 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 20.04.2015 20:44: Linus Torvalds torva...@linux-foundation.org writes: And to clarify: I don't suggest always building with libpcre. I literally suggest having something like /* hacky mac-hack hack */ if (strncmp((?i), p-pattern, 4)) {

Re: Why does git log -Gregex works with regexp-ignore-case but not with other regexp-related options?

2015-04-21 Thread Junio C Hamano
Michael J Gruber g...@drmicha.warpmail.net writes: We have engine-switching options and engine-modification options. The latter are certainly good in the expression itself. Maybe even the former, though I don't know how to switch away from fixed-strings in that way... I do not think mixing

Re: Why does git log -Gregex works with regexp-ignore-case but not with other regexp-related options?

2015-04-20 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 17.04.2015 19:45: On Fri, Apr 17, 2015 at 7:26 AM, Michael J Gruber g...@drmicha.warpmail.net wrote: Similarly I think it is not very consistent that one cannot combine any of the above options with the Sstring but instead have yet another option called

Re: Why does git log -Gregex works with regexp-ignore-case but not with other regexp-related options?

2015-04-20 Thread Junio C Hamano
Michael J Gruber g...@drmicha.warpmail.net writes: They [jc: -S and -G] have different semantics, and *therefore* they have different defaults, and *therefore* a user may want to switch one of them (or --grep or --author or...) to --fixed--strings and keep the other to --regexp. Ahh, OK.

Re: Why does git log -Gregex works with regexp-ignore-case but not with other regexp-related options?

2015-04-20 Thread Junio C Hamano
Linus Torvalds torva...@linux-foundation.org writes: And to clarify: I don't suggest always building with libpcre. I literally suggest having something like /* hacky mac-hack hack */ if (strncmp((?i), p-pattern, 4)) { p-pattern += 4; p-ignore_case = true; }

Re: Why does git log -Gregex works with regexp-ignore-case but not with other regexp-related options?

2015-04-20 Thread Linus Torvalds
On Mon, Apr 20, 2015 at 10:41 AM, Junio C Hamano gits...@pobox.com wrote: Ahh, OK. And not just -S and -G, the fields in headers may be something user may want to switch independently? So personally, I hate extra command line flags for this. I'd much rather see is use something in the regular

Why does git log -Gregex works with regexp-ignore-case but not with other regexp-related options?

2015-04-17 Thread Tim Friske
Hi, I wonder why git log -Gregexp works with the regexp-ignore-case option but not with the other regexp-related options? Wouldn't it be useful to make the Gregex option support the following options? * basic-regexp * extended-regexp * fixed-strings * perl-regexp Similarly I think it

Re: Why does git log -Gregex works with regexp-ignore-case but not with other regexp-related options?

2015-04-17 Thread Michael J Gruber
Tim Friske venit, vidit, dixit 17.04.2015 12:00: Hi, I wonder why git log -Gregexp works with the regexp-ignore-case option but not with the other regexp-related options? Wouldn't it be useful to make the Gregex option support the following options? * basic-regexp * extended-regexp

Re: Why does git log -Gregex works with regexp-ignore-case but not with other regexp-related options?

2015-04-17 Thread Junio C Hamano
Michael J Gruber g...@drmicha.warpmail.net writes: Similarly I think it is not very consistent that one cannot combine any of the above options with the Sstring but instead have yet another option called pickaxe-regex to toggle between fixed-string and extended-regexp semantics for the

Re: Why does git log -Gregex works with regexp-ignore-case but not with other regexp-related options?

2015-04-17 Thread Junio C Hamano
Michael J Gruber g...@drmicha.warpmail.net writes: Similarly I think it is not very consistent that one cannot combine any of the above options with the Sstring but instead have yet another option called pickaxe-regex to toggle between fixed-string and extended-regexp semantics for the

Re: Why does git log -Gregex works with regexp-ignore-case but not with other regexp-related options?

2015-04-17 Thread Junio C Hamano
On Fri, Apr 17, 2015 at 7:26 AM, Michael J Gruber g...@drmicha.warpmail.net wrote: Similarly I think it is not very consistent that one cannot combine any of the above options with the Sstring but instead have yet another option called pickaxe-regex to toggle between fixed-string and