Re: ag/rebase-i-rewrite-todo, was Re: What's cooking in git.git (Jun 2018, #07; Thu, 28)

Hi Junio, On Fri, 6 Jul 2018, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Of course, at that point I will have to look through those 7 patches > > again, if only to verify that yes, they are still the same. > > That is something the patch author must help the reviewer with, no?

Re: ag/rebase-i-rewrite-todo, was Re: What's cooking in git.git (Jun 2018, #07; Thu, 28)

Johannes Schindelin writes: > Of course, at that point I will have to look through those 7 patches > again, if only to verify that yes, they are still the same. That is something the patch author must help the reviewer with, no? Have uncontroversial stuff early in the series, concentrate on

Re: ag/rebase-i-rewrite-todo, was Re: What's cooking in git.git (Jun 2018, #07; Thu, 28)

Hi Junio, On Fri, 6 Jul 2018, Junio C Hamano wrote: > Johannes Schindelin writes: > > > I would *strongly* encourage you to allow Alban to go back to the small, > > incremental patch series he sent before, because it will make it > > *substantially* easier to not only review, but also develop,

Re: ag/rebase-i-rewrite-todo, was Re: What's cooking in git.git (Jun 2018, #07; Thu, 28)

Johannes Schindelin writes: > The latest iteration of this is here: > https://public-inbox.org/git/20180702105717.26386-5-alban.gr...@gmail.com/T/#r8eea71077745d6f2c839acb6200bb8b2bea579d3 Good. I think we have it in tree now. > I would *strongly* encourage you to allow Alban to go back to

ag/rebase-i-rewrite-todo, was Re: What's cooking in git.git (Jun 2018, #07; Thu, 28)

Hi Junio, On Thu, 28 Jun 2018, Junio C Hamano wrote: > * ag/rebase-i-rewrite-todo (2018-06-15) 3 commits > - rebase--interactive: rewrite the edit-todo functionality in C > - editor: add a function to launch the sequence editor > - Merge branch 'bc/t3430-fixup' into ag/rebase-i-rewrite-todo >