Re: bisect gives strange answer

2005-08-11 Thread Junio C Hamano
Sanjoy Mahajan [EMAIL PROTECTED] writes: I'm having doing a stupidity with git, but here's what is confusing me about using bisect: If I start with a clean directory except for a 2.6 .git/ (where master = d95a1b4818f2fe38a3cfc9a7d5817dc9a1a69329), then do $ cd linux-2.6 $ ls $ cat

Re: bisect gives strange answer

2005-08-05 Thread Sanjoy Mahajan
If you see any sort of evidence that this would hold true I really like to know. I haven't found any evidence. When I rebuilt the kernels from scratch (exporting them into an empty directory using cg-export), I got reliable data and bisected down to a patch that probably was a problem. I will

Re: bisect gives strange answer

2005-08-04 Thread Greg KH
On Thu, Aug 04, 2005 at 03:23:28AM -0400, Sanjoy Mahajan wrote: Could you try this please? Thanks, it now finishes with the diff that I expected: 3d3c2ae1101c1f2dff7e2f9d514769779dbd2737 is first bad commit diff-tree 3d3c2ae1101c1f2dff7e2f9d514769779dbd2737 (from

Re: bisect gives strange answer

2005-08-04 Thread Sanjoy Mahajan
By any chance, is this patch causing you problems? No, sadly. But I had hopes! As I think about it more, there's no way it could, since I have CONFIG_HOTPLUG=y, so moving the CONFIG_HOTPLUG would not change anything (for those who don't know the patch, it is appended below). My latest

Re: bisect gives strange answer

2005-08-04 Thread Dave Jones
On Thu, Aug 04, 2005 at 06:41:41PM +0100, Sanjoy Mahajan wrote: By any chance, is this patch causing you problems? No, sadly. But I had hopes! As I think about it more, there's no way it could, since I have CONFIG_HOTPLUG=y, so moving the CONFIG_HOTPLUG would not change anything (for

Re: bisect gives strange answer

2005-08-04 Thread Sanjoy Mahajan
Em, if you don't compile/test those intermediate versions, how do you know whether to tag it good/bad ? Sorry, I wrote this part carelessly: If I had checked out and compiled those intermediate versions from scratch... I meant to emphasize the 'from scratch'. I did check out and compile

Re: bisect gives strange answer

2005-08-04 Thread Junio C Hamano
Dave Jones [EMAIL PROTECTED] writes: Em, if you don't compile/test those intermediate versions, how do you know whether to tag it good/bad ? I think Sanjoy is saying that they _were_ tested, and suspects that bisect didn't leave the right versions of the files in the work tree, so what was

bisect gives strange answer

2005-08-03 Thread Sanjoy Mahajan
I have been having lots of fun using 'git bisect' to find the commit that broke S3 wake on my laptop. But in its last step it gives an answer that cannot be right. I had not used git until now, so I may be missing something obvious: Corrections will be gratefully received. I'm using git from