Re: check-ref-format: include refs/ in the argument or to strip it?

2014-08-27 Thread Michael Haggerty
On 08/25/2014 09:09 PM, Jeff King wrote: [...] This patch introduces a new always mode for the core.logallrefupdates option which will log updates to everything under refs/, regardless where in the hierarchy it is (we still will not log things like ORIG_HEAD and FETCH_HEAD, which are known

Re: check-ref-format: include refs/ in the argument or to strip it?

2014-08-25 Thread Ronnie Sahlberg
On Fri, Aug 22, 2014 at 10:46 PM, Jeff King p...@peff.net wrote: On Fri, Aug 22, 2014 at 11:45:15AM -0700, Jonathan Nieder wrote: Junio C Hamano wrote: implication of which is that the 'at least one slash' rule was to expect things are 'refs/anything' so there will be at

Re: check-ref-format: include refs/ in the argument or to strip it?

2014-08-25 Thread Jonathan Nieder
Ronnie Sahlberg wrote: On Fri, Aug 22, 2014 at 10:46 PM, Jeff King p...@peff.net wrote: Yeah, this weird do not allow refs/foo behavior has continually confused me. Coincidentally I just noticed a case today where pack-refs treats refs/foo specially for no good reason:

Re: check-ref-format: include refs/ in the argument or to strip it?

2014-08-25 Thread Junio C Hamano
Ronnie Sahlberg sahlb...@google.com writes: There are also a lot of places where we assume that a refs will start with refs/heads/ and not just refs/ for_each_branch_ref(), log_ref_setup() (so no reflogs) is_branch() to name a few. for-each-BRANCH-ref and is-BRANCH are explicitly about

Re: check-ref-format: include refs/ in the argument or to strip it?

2014-08-25 Thread Jeff King
On Mon, Aug 25, 2014 at 11:26:36AM -0700, Jonathan Nieder wrote: It's still very puzzling to me. The comment came at the same time as the behavior, in v0.99.9~120 (git-check-ref-format: reject funny ref names, 2005-10-13). Before that, the behavior was even stranger --- it checked that

check-ref-format: include refs/ in the argument or to strip it?

2014-08-22 Thread Jonathan Nieder
Hi, Michael Haggerty wrote[1]: Jonathan Nieder wrote: The check-ref-format documentation is pretty unclear, but the intent is that it would be used like git check-ref-format heads/master (see the surviving examples in contrib/examples/). That way, it can enforce the rule (from

Re: check-ref-format: include refs/ in the argument or to strip it?

2014-08-22 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes: Michael Haggerty wrote[1]: Jonathan Nieder wrote: The check-ref-format documentation is pretty unclear, but the intent is that it would be used like git check-ref-format heads/master (see the surviving examples in contrib/examples/). That

Re: check-ref-format: include refs/ in the argument or to strip it?

2014-08-22 Thread Jonathan Nieder
Junio C Hamano wrote: implication of which is that the 'at least one slash' rule was to expect things are 'refs/anything' so there will be at least one. Even back then, that anything alone had at least one slash (e.g. heads/master), but the intention was *never* that we would

Re: check-ref-format: include refs/ in the argument or to strip it?

2014-08-22 Thread Jonathan Nieder
Junio C Hamano wrote: Michael Haggerty wrote[1]: Jonathan Nieder wrote: The check-ref-format documentation is pretty unclear, but the intent is that it would be used like git check-ref-format heads/master (see the surviving examples in contrib/examples/). That way, it can enforce the

Re: check-ref-format: include refs/ in the argument or to strip it?

2014-08-22 Thread Jeff King
On Fri, Aug 22, 2014 at 11:45:15AM -0700, Jonathan Nieder wrote: Junio C Hamano wrote: implication of which is that the 'at least one slash' rule was to expect things are 'refs/anything' so there will be at least one. Even back then, that anything alone had at least one

Re: check-ref-format: include refs/ in the argument or to strip it?

2014-08-22 Thread Junio C Hamano
On Fri, Aug 22, 2014 at 10:46 PM, Jeff King p...@peff.net wrote: After much head scratching over the years, I am of the opinion that nobody every really _meant_ to prevent refs/foo... Yup, that matches my understanding. -- To unsubscribe from this list: send the line unsubscribe git in the